From: Nathan Chancellor <natechancellor@gmail.com>
To: devel@driverdev.osuosl.org
Cc: "Todd Kjos" <tkjos@android.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, "Arve Hjønnevåg" <arve@android.com>,
"Nathan Chancellor" <natechancellor@gmail.com>,
"Martijn Coenen" <maco@android.com>
Subject: [PATCH 5/6] staging: android: vsoc: Fix ending '(' warnings in vsoc_ioctl
Date: Sun, 6 May 2018 18:13:27 -0700 [thread overview]
Message-ID: <20180507011328.11982-5-natechancellor@gmail.com> (raw)
In-Reply-To: <20180507011328.11982-1-natechancellor@gmail.com>
Fixes checkpatch.pl warnings about lines ending with parentheses.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/staging/android/vsoc.c | 25 +++++++++++--------------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/android/vsoc.c b/drivers/staging/android/vsoc.c
index 7e9cf3e4fa04..c460740f9561 100644
--- a/drivers/staging/android/vsoc.c
+++ b/drivers/staging/android/vsoc.c
@@ -552,10 +552,10 @@ static long vsoc_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
if (!node)
return -ENOMEM;
INIT_LIST_HEAD(&node->list);
- rv = do_create_fd_scoped_permission(
- region_p,
- node,
- (struct fd_scoped_permission_arg __user *)arg);
+ rv = do_create_fd_scoped_permission
+ (region_p,
+ node,
+ (struct fd_scoped_permission_arg __user *)arg);
if (!rv) {
mutex_lock(&vsoc_dev.mtx);
list_add(&node->list, &vsoc_dev.permissions);
@@ -582,9 +582,7 @@ static long vsoc_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
break;
case VSOC_MAYBE_SEND_INTERRUPT_TO_HOST:
- if (!atomic_xchg(
- reg_data->outgoing_signalled,
- 1)) {
+ if (!atomic_xchg(reg_data->outgoing_signalled, 1)) {
writel(reg_num, vsoc_dev.regs + DOORBELL);
return 0;
} else {
@@ -595,17 +593,16 @@ static long vsoc_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
case VSOC_SEND_INTERRUPT_TO_HOST:
writel(reg_num, vsoc_dev.regs + DOORBELL);
return 0;
-
case VSOC_WAIT_FOR_INCOMING_INTERRUPT:
- wait_event_interruptible(
- reg_data->interrupt_wait_queue,
- (atomic_read(reg_data->incoming_signalled) != 0));
+ wait_event_interruptible
+ (reg_data->interrupt_wait_queue,
+ (atomic_read(reg_data->incoming_signalled) != 0));
break;
case VSOC_DESCRIBE_REGION:
- return do_vsoc_describe_region(
- filp,
- (struct vsoc_device_region __user *)arg);
+ return do_vsoc_describe_region
+ (filp,
+ (struct vsoc_device_region __user *)arg);
case VSOC_SELF_INTERRUPT:
atomic_set(reg_data->incoming_signalled, 1);
--
2.17.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-05-07 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 1:13 [PATCH 1/6] staging: android: Kconfig; Remove excessive hyphens Nathan Chancellor
2018-05-07 1:13 ` [PATCH 2/6] staging: android: Clean up license identifiers Nathan Chancellor
2018-05-14 13:29 ` Dan Carpenter
2018-05-14 13:51 ` Greg Kroah-Hartman
2018-05-14 13:52 ` Justin Skists
2018-05-14 14:07 ` Dan Carpenter
2018-05-07 1:13 ` [PATCH 3/6] staging: android: vsoc: Fix ending '(' warnings in function defintions Nathan Chancellor
2018-05-14 13:31 ` Dan Carpenter
2018-05-07 1:13 ` [PATCH 4/6] staging: android: vsoc: Fix ending '(' warnings in do_destroy_fd_scoped_permission Nathan Chancellor
2018-05-07 1:13 ` Nathan Chancellor [this message]
2018-05-07 1:13 ` [PATCH 6/6] staging: android: vsoc: Fix ending '(' warnings in vsoc_probe_device Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507011328.11982-5-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).