From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751082AbeEGHTq (ORCPT ); Mon, 7 May 2018 03:19:46 -0400 Received: from mail.bootlin.com ([62.4.15.54]:43164 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbeEGHTn (ORCPT ); Mon, 7 May 2018 03:19:43 -0400 Date: Mon, 7 May 2018 09:19:31 +0200 From: Maxime Ripard To: Paul Kocialkowski Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Mark Rutland , Chen-Yu Tsai , Thierry Reding , devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet Message-ID: <20180507071931.tebv45yxrojxxkeb@flea> References: <20180506214901.23429-1-contact@paulk.fr> <20180506214901.23429-3-contact@paulk.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y6g2nzcki4pe24es" Content-Disposition: inline In-Reply-To: <20180506214901.23429-3-contact@paulk.fr> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --y6g2nzcki4pe24es Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, May 06, 2018 at 11:49:01PM +0200, Paul Kocialkowski wrote: > This adds support for the Ainol AW1, an A20-based 7" tablet from Ainol. >=20 > The following board-specific features are supported: > * LCD panel > * Backlight > * USB OTG > * Buttons > * Touchscreen (doesn't work without non-free firmware) > * Accelerometer > * Battery >=20 > The following are untested: > * Audio output > * Audio speakers > * USB via SPCI connector >=20 > The following are not supported: > * Wi-Fi > * Bluetooth > * NAND > * Audio via SPCI connector > * Audio via Bluetooth I2S >=20 > Signed-off-by: Paul Kocialkowski > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/sun7i-a20-ainol-aw1.dts | 275 ++++++++++++++++++++++ > 2 files changed, 276 insertions(+) > create mode 100644 arch/arm/boot/dts/sun7i-a20-ainol-aw1.dts >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 7e2424957809..4a80971f2bc9 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -946,6 +946,7 @@ dtb-$(CONFIG_MACH_SUN6I) +=3D \ > sun6i-a31s-sinovoip-bpi-m2.dtb \ > sun6i-a31s-yones-toptech-bs1078-v2.dtb > dtb-$(CONFIG_MACH_SUN7I) +=3D \ > + sun7i-a20-ainol-aw1.dtb \ > sun7i-a20-bananapi.dtb \ > sun7i-a20-bananapi-m1-plus.dtb \ > sun7i-a20-bananapro.dtb \ > diff --git a/arch/arm/boot/dts/sun7i-a20-ainol-aw1.dts b/arch/arm/boot/dt= s/sun7i-a20-ainol-aw1.dts > new file mode 100644 > index 000000000000..9a1d54a9f9a0 > --- /dev/null > +++ b/arch/arm/boot/dts/sun7i-a20-ainol-aw1.dts > @@ -0,0 +1,275 @@ > +/* > + * Copyright (C) 2018 Paul Kocialkowski > + * > + * SPDX-License-Identifier: GPL-2.0+ This should be your first line. Also, we usually license our DT under a dual license (GPL and MIT) so that other projects (like FreeBSD) can use them as well, instead of duplicating them. It would be great if you'd consider it. > + */ > + > +/dts-v1/; > +#include "sun7i-a20.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > +#include > +#include > + > +/ { > + model =3D "Ainol AW1"; > + compatible =3D "ainol,ainol-aw1", "allwinner,sun7i-a20"; > + > + aliases { > + serial0 =3D &uart0; > + }; > + > + chosen { > + stdout-path =3D "serial0:115200n8"; > + }; > + > + backlight: backlight { > + compatible =3D "pwm-backlight"; > + pwms =3D <&pwm 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels =3D <0 10 20 30 40 50 60 70 80 90 100>; The increase in perceived brightness should be linear. Usually, for PWMs backed backlight, an exponential list is a much better approximation. > + default-brightness-level =3D <5>; > + enable-gpios =3D <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */ > + }; > + > + panel: panel { > + compatible =3D "innolux,at070tn90"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + power-supply =3D <&panel_power>; > + backlight =3D <&backlight>; > + > + port@0 { > + reg =3D <0>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + panel_input: endpoint@0 { > + reg =3D <0>; > + remote-endpoint =3D <&tcon0_out_panel>; > + }; > + }; > + }; > + > + panel_power: panel_power { > + compatible =3D "regulator-fixed"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&panel_power_pin>; > + regulator-name =3D "panel-power"; > + regulator-min-microvolt =3D <10400000>; > + regulator-max-microvolt =3D <10400000>; > + gpio =3D <&pio 7 8 GPIO_ACTIVE_HIGH>; /* PH8 */ > + enable-active-high; > + regulator-boot-on; > + }; > +}; > + > +&codec { > + allwinner,pa-gpios =3D <&pio 7 15 GPIO_ACTIVE_HIGH>; /* PH15 */ > + status =3D "okay"; > +}; > + > +&cpu0 { > + cpu-supply =3D <®_dcdc2>; > +}; > + > +&de { > + status =3D "okay"; > +}; > + > +&ehci0 { > + status =3D "okay"; > +}; > + > +&ehci1 { > + status =3D "okay"; > +}; > + > +&i2c0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c0_pins_a>; > + status =3D "okay"; > + > + axp209: pmic@34 { > + reg =3D <0x34>; > + interrupt-parent =3D <&nmi_intc>; > + interrupts =3D <0 IRQ_TYPE_LEVEL_LOW>; > + }; > +}; > + > +&i2c1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c1_pins_a>; > + status =3D "okay"; > + > + lis3dh: accelerometer@18 { > + compatible =3D "st,lis3dh-accel"; > + reg =3D <0x18>; > + vdd-supply =3D <®_vcc3v3>; > + vddio-supply =3D <®_vcc3v3>; > + st,drdy-int-pin =3D <1>; > + }; > +}; > + > +&i2c2 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c2_pins_a>; > + status =3D "okay"; > + clock-frequency =3D <400000>; > + > + gsl1680: touchscreen@40 { > + compatible =3D "silead,gsl1680"; > + reg =3D <0x40>; > + interrupt-parent =3D <&pio>; > + interrupts =3D <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21 (PH21) */ > + power-gpios =3D <&pio 7 20 GPIO_ACTIVE_HIGH>; /* PH20 */ > + firmware-name =3D "gsl1680-ainol-aw1.fw"; > + touchscreen-size-x =3D <480>; > + touchscreen-size-y =3D <800>; > + touchscreen-swapped-x-y; > + touchscreen-inverted-y; > + silead,max-fingers =3D <5>; > + }; > +}; > + > +&lradc { > + vref-supply =3D <®_ldo2>; > + status =3D "okay"; > + > + button@571 { > + label =3D "Volume Up"; > + linux,code =3D ; > + channel =3D <0>; > + voltage =3D <571428>; > + }; > + > + button@761 { > + label =3D "Volume Down"; > + linux,code =3D ; > + channel =3D <0>; > + voltage =3D <761904>; > + }; > + > + button@952 { > + label =3D "Home"; > + linux,code =3D ; > + channel =3D <0>; > + voltage =3D <952380>; > + }; > +}; > + > +&mmc0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc0_pins_a>; > + vmmc-supply =3D <®_vcc3v3>; You have the regulators described in your DT, you'd better use them instead of the one coming from sunxi-common-regulators.dtsi. > + bus-width =3D <4>; > + cd-gpios =3D <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */ > + cd-inverted; > + status =3D "okay"; > +}; > + > +&ohci0 { > + status =3D "okay"; > +}; > + > +&ohci1 { > + status =3D "okay"; > +}; > + > +&otg_sram { > + status =3D "okay"; > +}; > + > +&pio { > + panel_power_pin: panel_power_pin@0 { > + pins =3D "PH8"; > + function =3D "gpio_out"; > + }; > +}; You don't need that pinctrl node. Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --y6g2nzcki4pe24es Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlrv/gIACgkQ0rTAlCFN r3S4UA//UubFJ13xD4IpAyFnbvWrCjeIWtq2X4UddRSR0w1iLgZb2e4piqvGLa5H QBOS89vTHtjPxJVhdtZkX4bTHy/E+GMa1fQuMNGlVetRvYQfUx9XXabFMwQXVgw9 8bdVeyB1AxNDm7PID49cjQcYJtW6005+e1CjMKi6/IR683iXhGqwuS9HfojwXK/Y oZakCLNWebFfY8fo91dtvjgzTWrgSvH3uDQKQDam3EBLLO0U3BRF9A6emrNQ33tz 3K/bxuk7B6zzbNHvG9ZUw9iruP4OBOfCBZaQnnWcwbC38OQ6XvnfEIm+haHJ8Awv CkOh2DCyMYvE47FKb65yfhB1bGGdOBySinnPkAazFtW2LC/1VzhtO+Ctdpl8A1Hk HMIwQAp1Ped7+2puRamhc9QVf0YRt1UyUaSShngjcGTMQEEm+sGNUS78GO5mpHKb Qu2bE0MVRsxhYPxjrt9X+faF3P3WDdm3LrIelmZqWn5W9M0s/k4U4avXVM2Aahff PxUwFLuOd5NOLKzr+XVcNoTibsKoEQXvXLORyR+dux0/NsmSFaH06QyOpkl62cxA 1w6B108mWaoFxLm6/Ea6dcg35gV+GPgBGnnifZpGpl8ZcPkNXDsakVjePIHxxQ/8 c3htBM+2niylOtDST0YVU+4YxKahTwZVKme8oUqYzqw8wB5gqy4= =RXn1 -----END PGP SIGNATURE----- --y6g2nzcki4pe24es--