From: Sakari Ailus <sakari.ailus@iki.fi>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: hans.verkuil@cisco.com, mchehab@kernel.org, robh+dt@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: media: i2c: Add mt9t111 image sensor
Date: Mon, 7 May 2018 12:17:54 +0300 [thread overview]
Message-ID: <20180507091753.fectimexhgyho3vk@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1524654014-17852-2-git-send-email-jacopo+renesas@jmondi.org>
Hi Jacopo,
On Wed, Apr 25, 2018 at 01:00:13PM +0200, Jacopo Mondi wrote:
> Add device tree bindings documentation for Micron MT9T111/MT9T112 image
> sensors.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> Documentation/devicetree/bindings/mt9t112.txt | 41 +++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mt9t112.txt
>
> diff --git a/Documentation/devicetree/bindings/mt9t112.txt b/Documentation/devicetree/bindings/mt9t112.txt
> new file mode 100644
> index 0000000..cbad475
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mt9t112.txt
> @@ -0,0 +1,41 @@
> +Micron 3.1Mp CMOS Digital Image Sensor
> +--------------------------------------
> +
> +The Micron MT9T111 and MT9T112 are 1/4 inch 3.1Mp System-On-A-Chip (SOC) CMOS
> +digital image sensors which support up to QXGA (2048x1536) image resolution in
> +4/3 format.
> +
> +The sensors can be programmed through a two-wire serial interface and can
> +work both in parallel data output mode as well as in MIPI CSI-2 mode.
> +
> +Required Properties:
> +- compatible: shall be one of the following values
> + "micron,mt9t111" for MT9T111 sensors
> + "micron,mt9t112" for MT9T112 sensors
> +
> +Optional properties:
> +- powerdown-gpios: reference to powerdown input GPIO signal. Pin name "STANDBY".
> + Active level is high.
> +
> +The device node shall contain one 'port' sub-node with one 'endpoint' child
> +node, modeled accordingly to bindings described in:
> +Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +--------
> +
> + mt9t112@3d {
> + compatible = "micron,mt9t112";
> + reg = <0x3d>;
> +
> + powerdown-gpios = <&gpio4 2 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + mt9t112_out: endpoint {
> + pclk-sample = <1>;
Could you document pclk-sample as an endpoint property? I'd suggest making
it optional with a default configuration.
> + remote-endpoint = <&ceu_in>;
> + };
> + };
> + };
> +
> +
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi
next prev parent reply other threads:[~2018-05-07 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 11:00 [PATCH 0/2] media: i2c: mt9t112: Add OF tree support Jacopo Mondi
2018-04-25 11:00 ` [PATCH 1/2] dt-bindings: media: i2c: Add mt9t111 image sensor Jacopo Mondi
2018-05-01 14:28 ` Rob Herring
2018-05-07 9:17 ` Sakari Ailus [this message]
2018-04-25 11:00 ` [PATCH 2/2] media: i2c: mt9t112: Add device tree support Jacopo Mondi
2018-05-07 9:32 ` Sakari Ailus
2018-05-14 14:30 ` jacopo mondi
2018-05-14 21:50 ` Sakari Ailus
2018-05-15 7:10 ` jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507091753.fectimexhgyho3vk@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).