From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZqwUbmQL2mRcDiTUEblI9YDqZXjdjqKiI9GUPKkBKGpjowqw5cXcAX3/R0dB08l69bBRXRy ARC-Seal: i=1; a=rsa-sha256; t=1525698404; cv=none; d=google.com; s=arc-20160816; b=RWWmsab2WzgFmygrRngmc7u4kmMPVEmQxnW2iKO+ub0Fcq54iBLC0cNN/suDAUGNO7 Ojbehdf2LobDjFAmPYYUaXEbdYgHOZV9Xy+fdbtqGwqm1H6+jFXdllJLRSFYVhyZqotf hBUyTV1e/wXNvtN/JDfey+jotHuJlgIGBoPwHdfpm5p9gNfr6VkLFinohXCwMF8P+y3D fqQQffRBwFzMGLmUrWxpC9V00M/XUyv+q5QHAzUKrqH34DP2QjdVp1c5zuck2sAZG8bX 8w4edLZ6Rg2fOE5KxcRs1xF+GHs841DcQgY9GsQ+omeq5EAAPcQEYIlyDnh96VuEuayx mdWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=NuH0mzUZc5TQOt0jVCw1MQLxIQP7xkNHsoATenmfgVU=; b=a3BVpi/u20gEBVP6hct4c4UdyufAeN+hOZi0f5Gvd+lI9GzQWzqNrAkKW7EQxDjVMH rcutb2OowBpCF9sQAb4CKeIGpGdkLm+ZNgyl9xjf06wu7XQMnLPKKWbHaGQNlXKXQboe pVkkKyrG+tMdG+XK7zQOMDjpR6tEO0E62zM9TNb+HtlvSvfmGgV42nx2v3iaLxkiGF6R sZNaJ14OPgxEpXqObgPN0O3eWhz+kh7ad+1gh+hCPkm5yPI8HSZEWVARGwoyANMB1DSo a3t5tDvAEImnrBkVQCpjAW5NBSwoIa/sGoHyasANsRw0oIUa3SmtNDYm+cV5yzXYjczf IfvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of ville.syrjala@linux.intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ville.syrjala@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of ville.syrjala@linux.intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ville.syrjala@linux.intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,374,1520924400"; d="scan'208";a="53070833" From: Ville Syrjala To: linux-bluetooth@vger.kernel.org Cc: Dmitry Torokhov , Greg Kroah-Hartman , Marcel Holtmann , Kay Sievers , systemd-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Subject: [PATCH bluez] hid2hci: Fix udev rules for linux-4.14+ Date: Mon, 7 May 2018 16:06:38 +0300 Message-Id: <20180507130638.3516-1-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.16.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1599810729643760049?= X-GMAIL-MSGID: =?utf-8?q?1599810729643760049?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Ville Syrjälä Since commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound to a driver") the kernel started emitting "bound" and "unbound" uevents which confuse the hid2hci udev rules. The symptoms on an affected machine (Dell E5400 in my case) include bluetooth devices not appearing and udev hogging the cpu as it's busy processing a constant stream of these "bound"+"unbound" uevents. Change the udev rules only kick in for an "add" event. This seems to cure my machine at least. Cc: Dmitry Torokhov Cc: Greg Kroah-Hartman Cc: Marcel Holtmann Cc: Kay Sievers Cc: systemd-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Cc: linux-bluetooth@vger.kernel.org Signed-off-by: Ville Syrjälä --- tools/hid2hci.rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hid2hci.rules b/tools/hid2hci.rules index db6bb03d2ef3..daa381d77387 100644 --- a/tools/hid2hci.rules +++ b/tools/hid2hci.rules @@ -1,6 +1,6 @@ # do not edit this file, it will be overwritten on update -ACTION=="remove", GOTO="hid2hci_end" +ACTION!="add", GOTO="hid2hci_end" SUBSYSTEM!="usb*", GOTO="hid2hci_end" # Variety of Dell Bluetooth devices - match on a mouse device that is -- 2.16.1