From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Johan Hovold <johan@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-can@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
Robin Murphy <robin.murphy@arm.com>,
kernel@pengutronix.de, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 3/3] tty: implement led triggers
Date: Tue, 8 May 2018 12:51:31 +0200 [thread overview]
Message-ID: <20180508105131.agz7u3q42gy7mrxy@pengutronix.de> (raw)
In-Reply-To: <20180508100851.GY2285@localhost>
On Tue, May 08, 2018 at 12:08:51PM +0200, Johan Hovold wrote:
> On Tue, May 08, 2018 at 12:05:43PM +0200, Uwe Kleine-König wrote:
> > The rx trigger fires when data is pushed to the ldisc by the driver. This
> > is a bit later than the actual receiving of data but has the nice benefit
> > that it doesn't need adaption for each driver and isn't in the hot path.
> >
> > Similarly the tx trigger fires when data was copied from userspace and is
> > given to the ldisc.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx25-logitech-baby.dts | 192 ++++++++++++++++++++++
>
> Looks like you included more than intended in this patch.
Right, this doesn't belong here. Feel free to assume I didn't include it
in the patch and comment the rest :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-05-08 10:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 10:05 [PATCH v3 0/3] led_trigger_register_format and tty triggers Uwe Kleine-König
2018-05-08 10:05 ` [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format() Uwe Kleine-König
2018-05-08 19:33 ` Jacek Anaszewski
2018-05-08 20:17 ` Uwe Kleine-König
2018-05-09 19:57 ` Jacek Anaszewski
2018-05-10 11:21 ` Pavel Machek
2018-05-10 11:22 ` Pavel Machek
2018-05-12 18:59 ` Uwe Kleine-König
2018-05-13 14:34 ` Andy Shevchenko
2018-05-08 10:05 ` [PATCH v3 2/3] can: simplify LED trigger handling Uwe Kleine-König
2018-05-08 11:04 ` Marc Kleine-Budde
2018-05-08 10:05 ` [PATCH v3 3/3] tty: implement led triggers Uwe Kleine-König
2018-05-08 10:08 ` Johan Hovold
2018-05-08 10:51 ` Uwe Kleine-König [this message]
2018-05-13 14:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508105131.agz7u3q42gy7mrxy@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=f.fainelli@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=pavel@ucw.cz \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).