From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2742904-1525779921-2-14925818841734088586 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, UNPARSEABLE_RELAY 0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1525779920; b=JCWPtpbZHwSCfUkzYI0aF8AgTp1rp2Tspp7CFAlM2o4nqqOGs3 UBAeXg1hRwTP9T+bqUJg1qm9fvwDKrfzZgjnlSZBwasE9VeHtz812pPlcYgdAEn6 Aby+OM79Jb/i0PWQYuW4G0YLf44LESKvuEfhMTpcWkUULMlFWTxHwcIMPJTdEAD8 TCmld6p5JYZ7AnsmHFpmxsWrPQY/Y9CQ5XSqsirVO0be21nzeb5F/ozLdZdYs3XZ 3V+nEeGignCJ8DFRspqNuFcrhCkuGGBvq6N8yHKvoB74fs6KOfdD1tUOlHjo7oyA TdDG+E8IQ/5RvxJXQ0kb8oWFfH71M8rEYFpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=fm2; t=1525779920; bh=5ZEDZ Rc59Zyw+OZvOaZPSjDGnh2PnvZrTo8IdhWyS1s=; b=be11CQ1PVMjdLd/K9ueWl ACJcZXVXvsxP1OJUptAhbOYCc7+LfYFRBAb6IO/L/ndhvw+lqj+N1opEcmqsxFW6 hkS1btMCfvZUsN9SHFug0oCQEhqAf6jKVk/Kswtq8pYKU+lrLvlz+8yuHoVZPQAT YStJ60hVlT9dpai8eSyc8E4HENqqja6dexCdFzSIHTGBIcN6cfBr0vbPsiZejeXT woLs6/9aLLeTccqa2nMyubp4rMtUpTxpRRv8OJx3JzycjymtCfzveQXcxjJRmZcQ ZxEPc/5oyiI1tqpKgtB7SkxaN6FUvd/L8IjVjY2ESaozlcSP/cYl8tSi40oUImbu A== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=TJCHga09 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-cm=discussion score=0; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=TJCHga09 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-cm=discussion score=0; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfKfzSkYdEINvDso5B63OLh7DBLGSPFW5qmBywFzG8F5cgtTZBNat4p0SQUjLT26lqzZcTUoMHb4W9ocayf3D9gkiFE1dolLyquIYZjwVRTvlmrrZ5Yy3 /pn/tTASyT2muszBahjwidxHG0vgrpF26t6lD0wOZpaaeLSSPYKi+u63Ar5muuULY29BNEutAIBnQEIe5JYJKMIL2OR9siIyjSMnzn3sR6/P7FlnHjadb704 t80QNPyCFINIhbM+WG2Qkg== X-CM-Analysis: v=2.3 cv=FKU1Odgs c=1 sm=1 tr=0 a=28bQ1EhdAjTzU1YDPmtEKw==:117 a=28bQ1EhdAjTzU1YDPmtEKw==:17 a=kj9zAlcOel0A:10 a=VUJBJC2UJ8kA:10 a=-uNXE31MpBQA:10 a=jJxKW8Ag-pUA:10 a=VwQbUJbxAAAA:8 a=DDOyTI_5AAAA:8 a=ePMl53OVLegmtRm86RsA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=_BcfOz0m4U4ohdxiHPKc:22 cc=dsc X-ME-CMScore: 0 X-ME-CMCategory: discussion X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Tue, 8 May 2018 14:45:00 +0300 From: Dan Carpenter To: James Simmons Subject: Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode Message-ID: <20180508114500.qrtnjax4siupgv3n@mwanda> References: <1525285308-15347-1-git-send-email-jsimmons@infradead.org> <1525285308-15347-5-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1525285308-15347-5-git-send-email-jsimmons@infradead.org> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8886 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805080113 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Andreas Dilger , Greg Kroah-Hartman , NeilBrown , Linux Kernel Mailing List , Oleg Drokin , Jinshan Xiong , Lai Siyao , Lustre Development List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: > /* > * Allocate new object. This may result in rather complicated > * operations, including fld queries, inode loading, etc. > */ > o = lu_object_alloc(env, dev, f, conf); > - if (IS_ERR(o)) > + if (unlikely(IS_ERR(o))) > return o; > This is an unrelated and totally pointless. likely/unlikely annotations hurt readability, and they should only be added if it's something which is going to show up in benchmarking. lu_object_alloc() is already too slow for the unlikely() to make a difference and anyway IS_ERR() has an unlikely built in so it's duplicative... Anyway, I understand that Intel has been ignoring kernel.org instead of sending forwarding their patches properly so you're doing a difficult and thankless job... Thanks for that. I'm sure it's frustrating to look at these patches for you as well. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel