From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: kgunda@codeaurora.org
Cc: Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral
Date: Tue, 8 May 2018 10:17:36 -0700 [thread overview]
Message-ID: <20180508171736.GJ2259@tuxbook-pro> (raw)
In-Reply-To: <f970143860bd64624e7fad58333df1be@codeaurora.org>
On Tue 08 May 03:25 PDT 2018, kgunda@codeaurora.org wrote:
> On 2018-05-07 21:50, Bjorn Andersson wrote:
> > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
[..]
> > > +- qcom,ovp
> > > + Usage: optional
> > > + Value type: <u32>
> > > + Definition: mV; Over-voltage protection limit;
> >
> > The existing users of qcom,pm8941-wled depends on this being in V, so
> > you can't change the unit. I suggest that you add a new "qcom,ovp-mv"
> > property and make the driver fall back to looking for qcom,ovp if that
> > isn't specified.
> >
> > PS. This is a very good example of why it is a good idea to not
> > restructure and make changes at the same time - I almost missed this.
> >
> Actually I have checked the current kernel and none of the properties are
> being configured from the device tree node. Hence, i thought it is the right
> time modify the units to mV to support the PMI8998.
>
arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dts does.
> You still want to have the qcom,ovp-mv, even though it is not being
> configured from device tree ?
Yes, please.
> > > + For pm8941: one of 27000, 29000, 32000, 35000
> > > + Default: 29000 mV
> > > + For pmi8998: one of 18100, 19600, 29600, 31100
> > > + Default: 29600 mV
> > > +
Regards,
Bjorn
next prev parent reply other threads:[~2018-05-08 17:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 9:57 [PATCH V1 0/5] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2018-05-03 9:57 ` [PATCH V1 1/5] qcom: wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-05-07 15:41 ` Bjorn Andersson
2018-05-10 11:10 ` Pavel Machek
2018-05-03 9:57 ` [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-05-07 16:20 ` Bjorn Andersson
2018-05-08 10:25 ` kgunda
2018-05-08 17:17 ` Bjorn Andersson [this message]
2018-05-09 5:15 ` kgunda
2018-05-17 9:47 ` kgunda
2018-05-17 12:31 ` Rob Herring
2018-05-17 15:10 ` kgunda
2018-05-18 12:20 ` Rob Herring
2018-05-14 16:57 ` Pavel Machek
2018-05-15 4:55 ` kgunda
2018-05-03 9:57 ` [PATCH V1 3/5] backlight: qcom-wled: Add support for short circuit handling Kiran Gunda
2018-05-07 8:06 ` Dan Carpenter
2018-05-07 9:08 ` kgunda
2018-05-07 17:06 ` Bjorn Andersson
2018-05-08 10:35 ` kgunda
2018-05-03 9:57 ` [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling Kiran Gunda
2018-05-07 17:21 ` Bjorn Andersson
2018-05-08 12:26 ` kgunda
2018-05-08 17:19 ` Bjorn Andersson
2018-05-09 5:06 ` kgunda
2018-05-09 6:16 ` kgunda
2018-05-03 9:57 ` [PATCH V1 5/5] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2018-05-07 18:10 ` Bjorn Andersson
2018-05-09 7:14 ` kgunda
2018-05-14 17:02 ` Bjorn Andersson
2018-05-15 4:50 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508171736.GJ2259@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).