From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/memblock: print memblock_remove
Date: Wed, 9 May 2018 17:18:25 +0900 [thread overview]
Message-ID: <20180509081825.GA220810@rodete-desktop-imager.corp.google.com> (raw)
In-Reply-To: <20180509081214.GE32366@dhcp22.suse.cz>
On Wed, May 09, 2018 at 10:12:14AM +0200, Michal Hocko wrote:
> On Tue 08-05-18 19:42:23, Minchan Kim wrote:
> > memblock_remove report is useful to see why MemTotal of /proc/meminfo
> > between two kernels makes difference.
> >
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
> > mm/memblock.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/mm/memblock.c b/mm/memblock.c
> > index 5228f594b13c..03d48d8835ba 100644
> > --- a/mm/memblock.c
> > +++ b/mm/memblock.c
> > @@ -697,6 +697,11 @@ static int __init_memblock memblock_remove_range(struct memblock_type *type,
> >
> > int __init_memblock memblock_remove(phys_addr_t base, phys_addr_t size)
> > {
> > + phys_addr_t end = base + size - 1;
> > +
> > + memblock_dbg("memblock_remove: [%pa-%pa] %pS\n",
> > + &base, &end, (void *)_RET_IP_);
>
> Other callers of memblock_dbg use %pF. Is there any reason to be
> different here?
checkpatch hit me.
WARNING: Deprecated vsprintf pointer extension '%pF' - use %pS instead
#24: FILE: mm/memblock.c:702:
+ memblock_dbg("memblock_remove: [%pa-%pa] %pF\n",
+ &base, &end, (void *)_RET_IP_);
>
> Other that that looks ok to me.
Thanks, Michal.
next prev parent reply other threads:[~2018-05-09 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 10:42 [PATCH] mm/memblock: print memblock_remove Minchan Kim
2018-05-09 8:12 ` Michal Hocko
2018-05-09 8:18 ` Minchan Kim [this message]
2018-05-09 8:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509081825.GA220810@rodete-desktop-imager.corp.google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).