From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935092AbeEIOZt (ORCPT ); Wed, 9 May 2018 10:25:49 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:58165 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933887AbeEIOZr (ORCPT ); Wed, 9 May 2018 10:25:47 -0400 Date: Wed, 9 May 2018 16:25:45 +0200 From: Pavel Machek To: Sebastian Reichel Cc: Nick Dyer , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Ezequiel Garcia , kernel@collabora.com Subject: Re: [PATCHv2] Input: atmel_mxt_ts - fix reset-gpio for level based irqs Message-ID: <20180509142545.GC25131@amd> References: <20180420172408.26164-1-sebastian.reichel@collabora.co.uk> <20180423115844.26281-1-sebastian.reichel@collabora.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Bu8it7iiRSEf40bY" Content-Disposition: inline In-Reply-To: <20180423115844.26281-1-sebastian.reichel@collabora.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Bu8it7iiRSEf40bY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2018-04-23 13:58:44, Sebastian Reichel wrote: > The current reset-gpio support triggers an interrupt storm on platforms > using the maxtouch with level based interrupt. The Motorola Droid 4, > which I used for some of the tests is not affected, since it uses a edge > based interrupt. >=20 > This change avoids the interrupt storm by enabling the device while its > interrupt is disabled. Afterwards we wait 100ms. This is important for > two reasons: The device is unresponsive for some time (~22ms for > mxt224E) and the CHG (interrupt) line is not working properly for 100ms. > We don't need to wait for any following interrupts, since the following > mxt_initialize() checks for bootloader mode anyways. >=20 > This fixes a boot issue on GE PPD (watchdog kills device due to > interrupt storm) and does not cause regression on Motorola Droid 4. Out of curiosity, what is "GE PPD"? > Fixes: f657b00df22e ("Input: atmel_mxt_ts - add support for reset line") > Signed-off-by: Sebastian Reichel Reviewed-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --Bu8it7iiRSEf40bY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlrzBOkACgkQMOfwapXb+vIXWACfVtXLAzqzOfQ6qc7egfLguSG4 6SkAn05YpM1JDPfHM3vPhPg4CMw8vbqr =9fji -----END PGP SIGNATURE----- --Bu8it7iiRSEf40bY--