From: Oleg Nesterov <oleg@redhat.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Alexei Starovoitov <ast@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Steven Rostedt <rostedt@goodmis.org>,
Francis Deslauriers <francis.deslauriers@efficios.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
Borislav Petkov <bp@suse.de>, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH 2/2] uprobes: x86: Prohibit probing on MOV SS instruction
Date: Wed, 9 May 2018 18:39:40 +0200 [thread overview]
Message-ID: <20180509163939.GA26347@redhat.com> (raw)
In-Reply-To: <152587072544.17316.5950935243917346341.stgit@devbox>
On 05/09, Masami Hiramatsu wrote:
>
> Since MOV SS and POP SS instructions will delay the exceptions
> until the next instruction is executed, we should not do
> single-stepping on it by uprobes.
...
> --- a/arch/x86/kernel/uprobes.c
> +++ b/arch/x86/kernel/uprobes.c
> @@ -299,6 +299,10 @@ static int uprobe_init_insn(struct arch_uprobe *auprobe, struct insn *insn, bool
> if (is_prefix_bad(insn))
> return -ENOTSUPP;
>
> + /* We should not singlestep on the exception masking instructions */
> + if (insn_masking_exception(insn))
> + return -ENOTSUPP;
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2018-05-09 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 12:57 [PATCH 0/2] uprobes: x86: Reject probing MOV SS Masami Hiramatsu
2018-05-09 12:58 ` [PATCH 1/2] kprobes: x86: Prohibit probing on exception masking instructions Masami Hiramatsu
2018-05-13 17:57 ` [tip:x86/urgent] kprobes/x86: " tip-bot for Masami Hiramatsu
2018-05-09 12:58 ` [PATCH 2/2] uprobes: x86: Prohibit probing on MOV SS instruction Masami Hiramatsu
2018-05-09 16:39 ` Oleg Nesterov [this message]
2018-05-13 17:58 ` [tip:x86/urgent] uprobes/x86: " tip-bot for Masami Hiramatsu
2018-05-09 13:01 ` [PATCH 0/2] uprobes: kprobes: x86: Reject probing MOV SS/POP SS Masami Hiramatsu
2018-05-09 14:36 ` [PATCH 0/2] uprobes: x86: Reject probing MOV SS Andy Lutomirski
2018-05-09 22:25 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509163939.GA26347@redhat.com \
--to=oleg@redhat.com \
--cc=ast@kernel.org \
--cc=bp@suse.de \
--cc=davem@davemloft.net \
--cc=francis.deslauriers@efficios.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).