From: Peter Rosin <peda@axentia.se>
To: linux-kernel@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
linux-i2c@vger.kernel.org
Subject: [PATCH 2/2] i2c: pmcmsp: fix error return from master_xfer
Date: Wed, 9 May 2018 21:46:30 +0200 [thread overview]
Message-ID: <20180509194630.29047-2-peda@axentia.se> (raw)
In-Reply-To: <20180509194630.29047-1-peda@axentia.se>
Returning -1 (-EPERM) is not appropriate here, go with -EIO.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-pmcmsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c
index ec27e27e8d06..dae8ac618a52 100644
--- a/drivers/i2c/busses/i2c-pmcmsp.c
+++ b/drivers/i2c/busses/i2c-pmcmsp.c
@@ -564,7 +564,7 @@ static int pmcmsptwi_master_xfer(struct i2c_adapter *adap,
* TODO: We could potentially loop and retry in the case
* of MSP_TWI_XFER_TIMEOUT.
*/
- return -1;
+ return -EIO;
}
return num;
--
2.11.0
next prev parent reply other threads:[~2018-05-09 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 19:46 [PATCH 1/2] i2c: pmcmsp: return message count on master_xfer success Peter Rosin
2018-05-09 19:46 ` Peter Rosin [this message]
2018-05-15 7:28 ` [PATCH 2/2] i2c: pmcmsp: fix error return from master_xfer Wolfram Sang
2018-05-15 7:28 ` [PATCH 1/2] i2c: pmcmsp: return message count on master_xfer success Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509194630.29047-2-peda@axentia.se \
--to=peda@axentia.se \
--cc=andriy.shevchenko@linux.intel.com \
--cc=garsilva@embeddedor.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).