From: Dimitri Sivanich <sivanich@hpe.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: sivanich@sgi.com, arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] misc: sgi-gru: Change return type to vm_fault_t
Date: Wed, 9 May 2018 14:46:57 -0500 [thread overview]
Message-ID: <20180509194657.GA7219@hpe.com> (raw)
In-Reply-To: <20180425045044.GA21558@jordon-HP-15-Notebook-PC>
Acked-by: Dimitri Sivanich <sivanich@hpe.com>
On Wed, Apr 25, 2018 at 10:20:44AM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
> v2: Updated the change log
>
> drivers/misc/sgi-gru/grumain.c | 2 +-
> drivers/misc/sgi-gru/grutables.h | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> index 3641f13..ab174f28 100644
> --- a/drivers/misc/sgi-gru/grumain.c
> +++ b/drivers/misc/sgi-gru/grumain.c
> @@ -926,7 +926,7 @@ struct gru_state *gru_assign_gru_context(struct gru_thread_state *gts)
> *
> * Note: gru segments alway mmaped on GRU_GSEG_PAGESIZE boundaries.
> */
> -int gru_fault(struct vm_fault *vmf)
> +vm_fault_t gru_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct gru_thread_state *gts;
> diff --git a/drivers/misc/sgi-gru/grutables.h b/drivers/misc/sgi-gru/grutables.h
> index b5e308b..3e041b6 100644
> --- a/drivers/misc/sgi-gru/grutables.h
> +++ b/drivers/misc/sgi-gru/grutables.h
> @@ -147,6 +147,7 @@
> #include <linux/mutex.h>
> #include <linux/wait.h>
> #include <linux/mmu_notifier.h>
> +#include <linux/mm_types.h>
> #include "gru.h"
> #include "grulib.h"
> #include "gruhandles.h"
> @@ -665,7 +666,7 @@ extern unsigned long gru_reserve_cb_resources(struct gru_state *gru,
> int cbr_au_count, char *cbmap);
> extern unsigned long gru_reserve_ds_resources(struct gru_state *gru,
> int dsr_au_count, char *dsmap);
> -extern int gru_fault(struct vm_fault *vmf);
> +extern vm_fault_t gru_fault(struct vm_fault *vmf);
> extern struct gru_mm_struct *gru_register_mmu_notifier(void);
> extern void gru_drop_mmu_notifier(struct gru_mm_struct *gms);
>
> --
> 1.9.1
>
prev parent reply other threads:[~2018-05-09 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 4:50 [PATCH v2] misc: sgi-gru: Change return type to vm_fault_t Souptick Joarder
2018-05-09 19:46 ` Dimitri Sivanich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509194657.GA7219@hpe.com \
--to=sivanich@hpe.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).