From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756323AbeEJB2N (ORCPT ); Wed, 9 May 2018 21:28:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:42802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753270AbeEJB2M (ORCPT ); Wed, 9 May 2018 21:28:12 -0400 Date: Thu, 10 May 2018 10:28:08 +0900 From: Masami Hiramatsu To: Ravi Bangoria Cc: acme@kernel.org, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf buildid-cache: Warn --purge-all failures Message-Id: <20180510102808.5fcc479ccda0dd0eb08b7383@kernel.org> In-Reply-To: <20180509145205.3241-1-ravi.bangoria@linux.ibm.com> References: <20180509145205.3241-1-ravi.bangoria@linux.ibm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 May 2018 20:22:05 +0530 Ravi Bangoria wrote: > Warn perf buildid-cache --purge-all failures in non verbose mode. > Ex, > > $ sudo chown root:root /home/ravi/.debug -R > $ ./perf buildid-cache -P > Error: Permission denied. > > Suggested-by: Masami Hiramatsu > Signed-off-by: Ravi Bangoria > --- > tools/perf/builtin-buildid-cache.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c > index 7a7403913b57..ef6b3cc8d57d 100644 > --- a/tools/perf/builtin-buildid-cache.c > +++ b/tools/perf/builtin-buildid-cache.c > @@ -488,8 +488,12 @@ int cmd_buildid_cache(int argc, const char **argv) > } > } > > - if (purge_all) > - ret = build_id_cache__purge_all(); > + if (purge_all) { > + if (build_id_cache__purge_all()) { > + pr_warning("Error: %s.\n", > + str_error_r(errno, sbuf, sizeof(sbuf))); I would like to see "Couldn't remove some caches: error reason..." as same as other error messages. Thank you, > + } > + } > > if (missing_filename) > ret = build_id_cache__fprintf_missing(session, stdout); > -- > 2.14.3 > -- Masami Hiramatsu