linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4.17 1/2] Revert "ssb: Prevent build of PCI host features in module"
@ 2018-05-10 11:14 Rafał Miłecki
  2018-05-10 11:14 ` [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
  0 siblings, 1 reply; 9+ messages in thread
From: Rafał Miłecki @ 2018-05-10 11:14 UTC (permalink / raw)
  To: Kalle Valo, Michael Büsch, Larry Finger, Matt Redfearn
  Cc: linux-wireless, Hauke Mehrtens, LKML, Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e.

Above commit added "SSB = y" dependency to the wrong symbol
SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being
selected when needed. PCI core driver for core running in clienthost
mode is important for bus initialization. It's perfectly valid scenario
to have ssb built as module and use it with buses on PCI cards.

This fixes regression that affected all *module* users with PCI cards.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1572349
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/ssb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 9371651d8017..b3f5cae98ea6 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -117,7 +117,7 @@ config SSB_SERIAL
 
 config SSB_DRIVER_PCICORE_POSSIBLE
 	bool
-	depends on SSB_PCIHOST && SSB = y
+	depends on SSB_PCIHOST
 	default y
 
 config SSB_DRIVER_PCICORE
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
  2018-05-10 11:14 [PATCH 4.17 1/2] Revert "ssb: Prevent build of PCI host features in module" Rafał Miłecki
@ 2018-05-10 11:14 ` Rafał Miłecki
  2018-05-10 11:17   ` Michael Büsch
  2018-05-10 16:07   ` Larry Finger
  0 siblings, 2 replies; 9+ messages in thread
From: Rafał Miłecki @ 2018-05-10 11:14 UTC (permalink / raw)
  To: Kalle Valo, Michael Büsch, Larry Finger, Matt Redfearn
  Cc: linux-wireless, Hauke Mehrtens, LKML, Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
symbols pcibios_enable_device and register_pci_controller. This code is
supposed to be compiled only with ssb builtin.

This fixes:
ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/ssb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index b3f5cae98ea6..c574dd210500 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE
 
 config SSB_PCICORE_HOSTMODE
 	bool "Hostmode support for SSB PCI core"
-	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
+	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && SSB = y
 	help
 	  PCIcore hostmode operation (external PCI bus).
 
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
  2018-05-10 11:14 ` [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
@ 2018-05-10 11:17   ` Michael Büsch
  2018-05-10 11:20     ` Rafał Miłecki
  2018-05-10 16:07   ` Larry Finger
  1 sibling, 1 reply; 9+ messages in thread
From: Michael Büsch @ 2018-05-10 11:17 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Kalle Valo, Larry Finger, Matt Redfearn, linux-wireless,
	Hauke Mehrtens, LKML, Rafał Miłecki

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

On Thu, 10 May 2018 13:14:01 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
> symbols pcibios_enable_device and register_pci_controller. This code is
> supposed to be compiled only with ssb builtin.
> 
> This fixes:
> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  drivers/ssb/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
> index b3f5cae98ea6..c574dd210500 100644
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE
>  
>  config SSB_PCICORE_HOSTMODE
>  	bool "Hostmode support for SSB PCI core"
> -	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
> +	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && SSB = y
>  	help
>  	  PCIcore hostmode operation (external PCI bus).
>  


I think we also need to depend on PCI_DRIVERS_LEGACY.
See the other patch that floats around.


-- 
Michael

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
  2018-05-10 11:17   ` Michael Büsch
@ 2018-05-10 11:20     ` Rafał Miłecki
  2018-05-10 11:26       ` Michael Büsch
  0 siblings, 1 reply; 9+ messages in thread
From: Rafał Miłecki @ 2018-05-10 11:20 UTC (permalink / raw)
  To: Michael Büsch
  Cc: Kalle Valo, Larry Finger, Matt Redfearn, linux-wireless,
	Hauke Mehrtens, LKML, Rafał Miłecki

On 10 May 2018 at 13:17, Michael Büsch <m@bues.ch> wrote:
> On Thu, 10 May 2018 13:14:01 +0200
> Rafał Miłecki <zajec5@gmail.com> wrote:
>
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
>> symbols pcibios_enable_device and register_pci_controller. This code is
>> supposed to be compiled only with ssb builtin.
>>
>> This fixes:
>> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
>> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>>  drivers/ssb/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
>> index b3f5cae98ea6..c574dd210500 100644
>> --- a/drivers/ssb/Kconfig
>> +++ b/drivers/ssb/Kconfig
>> @@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE
>>
>>  config SSB_PCICORE_HOSTMODE
>>       bool "Hostmode support for SSB PCI core"
>> -     depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
>> +     depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && SSB = y
>>       help
>>         PCIcore hostmode operation (external PCI bus).
>>
>
>
> I think we also need to depend on PCI_DRIVERS_LEGACY.
> See the other patch that floats around.

I believe it's already handled by SSB_PCIHOST_POSSIBLE's dependency on
PCI_DRIVERS_LEGACY.

-- 
Rafał

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
  2018-05-10 11:20     ` Rafał Miłecki
@ 2018-05-10 11:26       ` Michael Büsch
  2018-05-10 11:35         ` Matt Redfearn
  2018-05-10 11:35         ` Rafał Miłecki
  0 siblings, 2 replies; 9+ messages in thread
From: Michael Büsch @ 2018-05-10 11:26 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Kalle Valo, Larry Finger, Matt Redfearn, linux-wireless,
	Hauke Mehrtens, LKML, Rafał Miłecki

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

On Thu, 10 May 2018 13:20:01 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

> On 10 May 2018 at 13:17, Michael Büsch <m@bues.ch> wrote:
> > On Thu, 10 May 2018 13:14:01 +0200
> > Rafał Miłecki <zajec5@gmail.com> wrote:
> >  
> >> From: Rafał Miłecki <rafal@milecki.pl>
> >>
> >> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
> >> symbols pcibios_enable_device and register_pci_controller. This code is
> >> supposed to be compiled only with ssb builtin.
> >>
> >> This fixes:
> >> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
> >> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
> >> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
> >>
> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> >> ---
> >>  drivers/ssb/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
> >> index b3f5cae98ea6..c574dd210500 100644
> >> --- a/drivers/ssb/Kconfig
> >> +++ b/drivers/ssb/Kconfig
> >> @@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE
> >>
> >>  config SSB_PCICORE_HOSTMODE
> >>       bool "Hostmode support for SSB PCI core"
> >> -     depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
> >> +     depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && SSB = y
> >>       help
> >>         PCIcore hostmode operation (external PCI bus).
> >>  
> >
> >
> > I think we also need to depend on PCI_DRIVERS_LEGACY.
> > See the other patch that floats around.  
> 
> I believe it's already handled by SSB_PCIHOST_POSSIBLE's dependency on
> PCI_DRIVERS_LEGACY.


That dependency seems to be wrong there.
Was it added among some other "let's just unbreak some random
build" change as well?

SSB_PCIHOST enables support for SSB on top of PCI. (Which is 99% of it
uses). I don't see how this uses the legacy API.

SSB_PCICORE_HOSTMODE enables PCI on top of SSB. Which is a MIPS corner
case. This uses the legacy MIPS API to register a PCI bus.

-- 
Michael

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
  2018-05-10 11:26       ` Michael Büsch
@ 2018-05-10 11:35         ` Matt Redfearn
  2018-05-10 11:35         ` Rafał Miłecki
  1 sibling, 0 replies; 9+ messages in thread
From: Matt Redfearn @ 2018-05-10 11:35 UTC (permalink / raw)
  To: Michael Büsch, Rafał Miłecki
  Cc: Kalle Valo, Larry Finger, linux-wireless, Hauke Mehrtens, LKML,
	Rafał Miłecki

Hi,

On 10/05/18 12:26, Michael Büsch wrote:
> On Thu, 10 May 2018 13:20:01 +0200
> Rafał Miłecki <zajec5@gmail.com> wrote:
> 
>> On 10 May 2018 at 13:17, Michael Büsch <m@bues.ch> wrote:
>>> On Thu, 10 May 2018 13:14:01 +0200
>>> Rafał Miłecki <zajec5@gmail.com> wrote:
>>>   
>>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>>
>>>> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
>>>> symbols pcibios_enable_device and register_pci_controller. This code is
>>>> supposed to be compiled only with ssb builtin.
>>>>
>>>> This fixes:
>>>> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
>>>> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
>>>> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>>>>
>>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>>> ---
>>>>   drivers/ssb/Kconfig | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
>>>> index b3f5cae98ea6..c574dd210500 100644
>>>> --- a/drivers/ssb/Kconfig
>>>> +++ b/drivers/ssb/Kconfig
>>>> @@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE
>>>>
>>>>   config SSB_PCICORE_HOSTMODE
>>>>        bool "Hostmode support for SSB PCI core"
>>>> -     depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
>>>> +     depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && SSB = y
>>>>        help
>>>>          PCIcore hostmode operation (external PCI bus).
>>>>   
>>>
>>>
>>> I think we also need to depend on PCI_DRIVERS_LEGACY.
>>> See the other patch that floats around.
>>
>> I believe it's already handled by SSB_PCIHOST_POSSIBLE's dependency on
>> PCI_DRIVERS_LEGACY.
> 
> 
> That dependency seems to be wrong there.
> Was it added among some other "let's just unbreak some random
> build" change as well?

Yeah - that was commit 58eae1416b80 ("ssb: Disable PCI host for 
PCI_DRIVERS_GENERIC").

> 
> SSB_PCIHOST enables support for SSB on top of PCI. (Which is 99% of it
> uses). I don't see how this uses the legacy API.
> 
> SSB_PCICORE_HOSTMODE enables PCI on top of SSB. Which is a MIPS corner
> case. This uses the legacy MIPS API to register a PCI bus.
> 

Yeah the dependency would seem to be in the wrong place and should be on 
SSB_PCICORE_HOSTMODE, in the same way as the bcma driver - commits 
664eadd6f44b ("bcma: Fix 'allmodconfig' and BCMA builds on MIPS 
targets") & 79ca239a68f8 ("bcma: Prevent build of PCI host features in 
module").

Thanks,
Matt

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
  2018-05-10 11:26       ` Michael Büsch
  2018-05-10 11:35         ` Matt Redfearn
@ 2018-05-10 11:35         ` Rafał Miłecki
  1 sibling, 0 replies; 9+ messages in thread
From: Rafał Miłecki @ 2018-05-10 11:35 UTC (permalink / raw)
  To: Michael Büsch
  Cc: Kalle Valo, Larry Finger, Matt Redfearn, linux-wireless,
	Hauke Mehrtens, LKML, Rafał Miłecki

On 10 May 2018 at 13:26, Michael Büsch <m@bues.ch> wrote:
> On Thu, 10 May 2018 13:20:01 +0200
> Rafał Miłecki <zajec5@gmail.com> wrote:
>
>> On 10 May 2018 at 13:17, Michael Büsch <m@bues.ch> wrote:
>> > On Thu, 10 May 2018 13:14:01 +0200
>> > Rafał Miłecki <zajec5@gmail.com> wrote:
>> >
>> >> From: Rafał Miłecki <rafal@milecki.pl>
>> >>
>> >> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
>> >> symbols pcibios_enable_device and register_pci_controller. This code is
>> >> supposed to be compiled only with ssb builtin.
>> >>
>> >> This fixes:
>> >> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
>> >> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
>> >> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>> >>
>> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> >> ---
>> >>  drivers/ssb/Kconfig | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
>> >> index b3f5cae98ea6..c574dd210500 100644
>> >> --- a/drivers/ssb/Kconfig
>> >> +++ b/drivers/ssb/Kconfig
>> >> @@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE
>> >>
>> >>  config SSB_PCICORE_HOSTMODE
>> >>       bool "Hostmode support for SSB PCI core"
>> >> -     depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
>> >> +     depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && SSB = y
>> >>       help
>> >>         PCIcore hostmode operation (external PCI bus).
>> >>
>> >
>> >
>> > I think we also need to depend on PCI_DRIVERS_LEGACY.
>> > See the other patch that floats around.
>>
>> I believe it's already handled by SSB_PCIHOST_POSSIBLE's dependency on
>> PCI_DRIVERS_LEGACY.
>
>
> That dependency seems to be wrong there.
> Was it added among some other "let's just unbreak some random
> build" change as well?

I guess so.


> SSB_PCIHOST enables support for SSB on top of PCI. (Which is 99% of it
> uses). I don't see how this uses the legacy API.
>
> SSB_PCICORE_HOSTMODE enables PCI on top of SSB. Which is a MIPS corner
> case. This uses the legacy MIPS API to register a PCI bus.

I agree current dependency on PCI_DRIVERS_LEGACY doesn't make sense.
It doesn't break thing though, thanks to the || !MIPS. I'm going to
fix that up in separated patch.

-- 
Rafał

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
  2018-05-10 11:14 ` [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
  2018-05-10 11:17   ` Michael Büsch
@ 2018-05-10 16:07   ` Larry Finger
  2018-05-11 10:18     ` Kalle Valo
  1 sibling, 1 reply; 9+ messages in thread
From: Larry Finger @ 2018-05-10 16:07 UTC (permalink / raw)
  To: Rafał Miłecki, Kalle Valo, Michael Büsch, Matt Redfearn
  Cc: linux-wireless, Hauke Mehrtens, LKML, Rafał Miłecki

On 05/10/2018 06:14 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
> symbols pcibios_enable_device and register_pci_controller. This code is
> supposed to be compiled only with ssb builtin.
> 
> This fixes:
> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

This patch needs a "Reported-by: Matt Redfearn <matt.redfearn@mips.com>".

Applying both patches leads to a correct configuration for PCI. I cannot test on 
my present hardware, but the patches seem to be correct.

Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net>

@Kalle: Please drop my patch from yesterday. This solution is much better.

Larry

> ---
>   drivers/ssb/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
> index b3f5cae98ea6..c574dd210500 100644
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE
>   
>   config SSB_PCICORE_HOSTMODE
>   	bool "Hostmode support for SSB PCI core"
> -	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
> +	depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && SSB = y
>   	help
>   	  PCIcore hostmode operation (external PCI bus).
>   
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
  2018-05-10 16:07   ` Larry Finger
@ 2018-05-11 10:18     ` Kalle Valo
  0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-05-11 10:18 UTC (permalink / raw)
  To: Larry Finger
  Cc: Rafał Miłecki, Michael Büsch, Matt Redfearn,
	linux-wireless, Hauke Mehrtens, LKML, Rafał Miłecki

Larry Finger <Larry.Finger@lwfinger.net> writes:

> On 05/10/2018 06:14 AM, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
>> symbols pcibios_enable_device and register_pci_controller. This code is
>> supposed to be compiled only with ssb builtin.
>>
>> This fixes:
>> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
>> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> This patch needs a "Reported-by: Matt Redfearn <matt.redfearn@mips.com>".
>
> Applying both patches leads to a correct configuration for PCI. I
> cannot test on my present hardware, but the patches seem to be
> correct.
>
> Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> @Kalle: Please drop my patch from yesterday. This solution is much better.

Dropped, thanks for letting me know.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-05-11 10:18 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 11:14 [PATCH 4.17 1/2] Revert "ssb: Prevent build of PCI host features in module" Rafał Miłecki
2018-05-10 11:14 ` [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
2018-05-10 11:17   ` Michael Büsch
2018-05-10 11:20     ` Rafał Miłecki
2018-05-10 11:26       ` Michael Büsch
2018-05-10 11:35         ` Matt Redfearn
2018-05-10 11:35         ` Rafał Miłecki
2018-05-10 16:07   ` Larry Finger
2018-05-11 10:18     ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).