From: Jean Delvare <jdelvare@suse.de>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: i801: mark PM functions as __maybe_unused
Date: Thu, 10 May 2018 15:27:19 +0200 [thread overview]
Message-ID: <20180510152719.6e37b10e@endymion> (raw)
In-Reply-To: <20180509190055.61ad929b@endymion>
On Wed, 9 May 2018 19:00:55 +0200, Jean Delvare wrote:
> If SIMPLE_DEV_PM_OPS causes it but UNIVERSAL_DEV_PM_OPS did not, I
> suppose that what matters is CONFIG_PM_SLEEP.
>
> So maybe we can just replace "#ifdef CONFIG_PM" with "ifdef
> CONFIG_PM_SLEEP" in the code below?
It seems that drivers i2c-brcmstb, i2c-mpc, i2c-ocores, i2c-pnx,
i2c-puv3, i2c-st, i2c-stu300 and i2c-mux-pca954x are doing exactly that
already, so that must be a valid way to solve the problem.
Will you send a new patch?
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2018-05-10 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 7:38 [PATCH] i2c: i801: mark PM functions as __maybe_unused Anders Roxell
2018-05-09 17:00 ` Jean Delvare
2018-05-10 13:27 ` Jean Delvare [this message]
2018-05-14 9:33 ` [PATCH v2] i2c: i801: fix unused-function warning Anders Roxell
2018-05-14 15:02 ` Jean Delvare
2018-05-14 17:18 ` Andy Shevchenko
2018-05-15 8:16 ` Jean Delvare
2018-05-17 13:54 ` Wolfram Sang
2018-05-25 21:09 [PATCH] i2c: i801: mark PM functions as __maybe_unused Arnd Bergmann
2018-05-25 21:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510152719.6e37b10e@endymion \
--to=jdelvare@suse.de \
--cc=anders.roxell@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).