From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbeEJSvk (ORCPT ); Thu, 10 May 2018 14:51:40 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:47016 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbeEJSvj (ORCPT ); Thu, 10 May 2018 14:51:39 -0400 X-Google-Smtp-Source: AB8JxZpe8tuG+mFB6yBwW/NPlNPLqmnDg9QEs3B77OvVIX21DHQk40SeX7nPGB5K78zUCyZAST0FFw== Date: Thu, 10 May 2018 14:51:38 -0400 From: Sean Paul To: Souptick Joarder Cc: Gustavo Padovan , Maarten Lankhorst , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH] gpu: drm: vgem: Change return type to vm_fault_t Message-ID: <20180510185138.GL33053@art_vandelay> References: <20180416150232.GA26745@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 10, 2018 at 07:58:11PM +0530, Souptick Joarder wrote: > Hi Sean, > > On Mon, Apr 16, 2018 at 8:32 PM, Souptick Joarder wrote: > > Use new return type vm_fault_t for fault handler. > > > > Signed-off-by: Souptick Joarder > > Reviewed-by: Matthew Wilcox > > --- > > drivers/gpu/drm/vgem/vgem_drv.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c > > index 2524ff1..c64a859 100644 > > --- a/drivers/gpu/drm/vgem/vgem_drv.c > > +++ b/drivers/gpu/drm/vgem/vgem_drv.c > > @@ -61,13 +61,13 @@ static void vgem_gem_free_object(struct drm_gem_object *obj) > > kfree(vgem_obj); > > } > > > > -static int vgem_gem_fault(struct vm_fault *vmf) > > +static vm_fault_t vgem_gem_fault(struct vm_fault *vmf) > > { > > struct vm_area_struct *vma = vmf->vma; > > struct drm_vgem_gem_object *obj = vma->vm_private_data; > > /* We don't use vmf->pgoff since that has the fake offset */ > > unsigned long vaddr = vmf->address; > > - int ret; > > + vm_fault_t ret = VM_FAULT_SIGBUS; > > loff_t num_pages; > > pgoff_t page_offset; > > page_offset = (vaddr - vma->vm_start) >> PAGE_SHIFT; > > @@ -77,7 +77,6 @@ static int vgem_gem_fault(struct vm_fault *vmf) > > if (page_offset > num_pages) > > return VM_FAULT_SIGBUS; > > > > - ret = -ENOENT; > > mutex_lock(&obj->pages_lock); > > if (obj->pages) { > > get_page(obj->pages[page_offset]); > > -- > > 1.9.1 > > > > Any further comment on this patch ? Patch looks good to me. My build test fails, though, since vm_fault_t doesn't exist in drm-misc-next yet. So, for now, Reviewed-by: Sean Paul -- Sean Paul, Software Engineer, Google / Chromium OS