From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4152212-1526052825-2-560657119299123463 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-charsets: plain='US-ASCII' X-Resolved-to: linux@kroah.com X-Delivered-to: linux@kroah.com X-Mail-from: linux-arch-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1526052824; b=eFh3uQN+cbFobamavqZTAoMzEIbw3afrOJTDtioNLc1CpGGliC A5ICoYNdHd/A4f0HSh8djLfyZE8R6nvJrCC29FB8N98+gmgwz6gNuShbg3AIC4/4 75CfJXpNyBhsGr75d3H1TtlVVCb4tae/IyL3QCEoeLOTtSRCyJ+yUzhU+3l2Hftm XEL69mWNaNkIB0vR+PoUs3T0yh8hedDJII0ePSwcahk/aWTX0JOGdk+x/t4sRYJW 0FJGLPSeGZC9Thfwl79Jv8Lk5DA7fGdUYBZADzQVCxo0aX9PlxAjzH9zkf63gP0F 0VZnRtDUzf9bIOLobP7gcqFEE/slm1Wf1F9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding:sender:list-id; s=fm2; t=1526052824; bh=Z+8cPviTVN3oejOohxsgH1l1XZKtuxxSizAwGQy2sZ4=; b=HfM4aiwqUr50 m9NQMZyFMPPdZ3MtNvPsxVvHS8+KL4Qy1gYQjIe4jqEAvEBRGubieNTV4qFykEew lF76h3aCS81gIDKX2nP5P+nvG1YwOPQjs4EBKRGWEuTVzDtSLpkKHbZGquNgKVoT lBzIdfbT9GbkBfHXgKDYIEejUBGnszcy5OqbOkM0IUFgXFrkLf6P/ZExOfy81YIT 9FQHgTDR+5ApNgHZiCtsiWmvS1nxAGXSSrAm5A8jUowaOggm4+G3qz3F+0jncqzj j9ZGTCG0wxuwcXWlUinu6P6Qhc32OMjrtPRzfaSiyLIaX+ffXQiEgeBMM96OrSnx ruCaAxklrw== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=goodmis.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-arch-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=goodmis.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=goodmis.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-arch-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=goodmis.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfGtrhuHcRSmgE3JRYRJGVSZQSdyeD/N8AHNC8CoKrhemnSPGy2Z4X1flOyuG/QNy5oKfHeW9fFOTBORN3DXMUsryQKZCQ3HoC1K/dJqSxuLC7RTO5Z0A 4NvMiLPfKfjFKem9iEBSF2bxUkeQwef2Iz5QCrkiczaTj56Cd6CSsfMKFvlqLZq71ocqZKUjR0iaxaKCy8VLz8IWZtdmeVinTxNgYUy+un+vph5GWRqRx5mN X-CM-Analysis: v=2.3 cv=E8HjW5Vl c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=kj9zAlcOel0A:10 a=VUJBJC2UJ8kA:10 a=7CQSdrXTAAAA:8 a=20KFwNOVAAAA:8 a=JfrnYn6hAAAA:8 a=meVymXHHAAAA:8 a=Dh-QJ09K9ePOfNaAm2QA:9 a=CjuIK1q_8ugA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 a=1CNFftbPRP8L7MoqJWF3:22 a=2JgSa4NbpEOStq-L5dxp:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751219AbeEKPdm (ORCPT ); Fri, 11 May 2018 11:33:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:56456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbeEKPdl (ORCPT ); Fri, 11 May 2018 11:33:41 -0400 Date: Fri, 11 May 2018 11:33:38 -0400 From: Steven Rostedt To: Dave Martin Cc: linux-kernel@vger.kernel.org, Ralf Baechle , James Hogan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "David S. Miller" , Ingo Molnar , Peter Zijlstra , Oleg Nesterov , linux-arch@vger.kernel.org Subject: Re: [PATCH REPOST 1/5] thread_info: Port core code to use update_thread_flag() helpers Message-ID: <20180511113338.1d828a50@gandalf.local.home> In-Reply-To: <1526051104-15995-2-git-send-email-Dave.Martin@arm.com> References: <1526051104-15995-1-git-send-email-Dave.Martin@arm.com> <1526051104-15995-2-git-send-email-Dave.Martin@arm.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org X-Mailing-List: linux-arch@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, 11 May 2018 16:05:00 +0100 Dave Martin wrote: > This patch ports a couple of relevant bits of the core kernel to > use the new update_thread_flag() helpers. > > No functional change. > > Signed-off-by: Dave Martin > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Oleg Nesterov > --- > include/trace/syscall.h | 6 ++---- > kernel/ptrace.c | 13 +++++-------- > 2 files changed, 7 insertions(+), 12 deletions(-) > > diff --git a/include/trace/syscall.h b/include/trace/syscall.h > index dc8ac27..dcc9bdf 100644 > --- a/include/trace/syscall.h > +++ b/include/trace/syscall.h > @@ -37,10 +37,8 @@ struct syscall_metadata { > #if defined(CONFIG_TRACEPOINTS) && defined(CONFIG_HAVE_SYSCALL_TRACEPOINTS) > static inline void syscall_tracepoint_update(struct task_struct *p) > { > - if (test_thread_flag(TIF_SYSCALL_TRACEPOINT)) > - set_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT); > - else > - clear_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT); > + update_tsk_thread_flag(p, TIF_SYSCALL_TRACEPOINT, > + test_thread_flag(TIF_SYSCALL_TRACEPOINT)); > } Acked-by: Steven Rostedt (VMware) -- Steve > #else > static inline void syscall_tracepoint_update(struct task_struct *p) > diff --git a/kernel/ptrace.c b/kernel/ptrace.c > index 21fec73..7a2bd8d 100644 > --- a/kernel/ptrace.c > +++ b/kernel/ptrace.c > @@ -785,16 +785,13 @@ static int ptrace_resume(struct task_struct *child, long request, > if (!valid_signal(data)) > return -EIO; > > - if (request == PTRACE_SYSCALL) > - set_tsk_thread_flag(child, TIF_SYSCALL_TRACE); > - else > - clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE); > + update_tsk_thread_flag(child, TIF_SYSCALL_TRACE, > + request == PTRACE_SYSCALL); > > #ifdef TIF_SYSCALL_EMU > - if (request == PTRACE_SYSEMU || request == PTRACE_SYSEMU_SINGLESTEP) > - set_tsk_thread_flag(child, TIF_SYSCALL_EMU); > - else > - clear_tsk_thread_flag(child, TIF_SYSCALL_EMU); > + update_tsk_thread_flag(child, TIF_SYSCALL_EMU, > + request == PTRACE_SYSEMU || > + request == PTRACE_SYSEMU_SINGLESTEP); > #endif > > if (is_singleblock(request)) {