From: Andrew Morton <akpm@linux-foundation.org>
To: Larry Chen <lchen@suse.com>
Cc: mfasheh@versity.com, jlbec@evilplan.org,
linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH] ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level
Date: Fri, 11 May 2018 14:22:56 -0700 [thread overview]
Message-ID: <20180511142256.ecabae077ddd5fb18df29959@linux-foundation.org> (raw)
In-Reply-To: <88053e38-350e-34a4-b3d8-431297dc1f90@suse.com>
On Fri, 11 May 2018 12:16:51 +0800 Larry Chen <lchen@suse.com> wrote:
> > Nice changelog, but it gives no information about the severity of the
> > bug: how often does it hit and what is the end-user impact.
> >
> > This info is needed so that I and others can decide which kernel
> > version(s) need the patch, so please always include it when fixing a
> > bug, thanks.
>
> Thanks for your review and feel sorry for not providing enough information.
>
> For the status quo of ocfs2, without this patch, neither a bug nor end-user
> impact will be caused because the wrong logic is avoided.
>
> But I'm afraid this generic interface, may be called by other
> developers in future and used in this situation.
>
> a process
> ocfs2_inode_lock_tracker(ex=0)
> ocfs2_inode_lock_tracker(ex=1)
OK, thanks.
> By the way, should I resend this patch with this info included?
I pasted the above into my copy of the changelog so we're good.
prev parent reply other threads:[~2018-05-11 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 5:32 [PATCH] ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level Larry Chen
2018-05-10 7:49 ` [Ocfs2-devel] " Gang He
2018-05-10 21:49 ` Andrew Morton
2018-05-11 4:16 ` Larry Chen
2018-05-11 21:22 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511142256.ecabae077ddd5fb18df29959@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jlbec@evilplan.org \
--cc=lchen@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@versity.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).