From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753202AbeEKOp3 (ORCPT ); Fri, 11 May 2018 10:45:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:50298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752952AbeEKOp2 (ORCPT ); Fri, 11 May 2018 10:45:28 -0400 Date: Fri, 11 May 2018 11:45:26 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , "H. Peter Anvin" , Andi Kleen , Alexander Shishkin , Dave Hansen , Joerg Roedel , Jiri Olsa , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH RFC 07/19] perf tools: Workaround missing maps for x86_64 KPTI entry trampolines Message-ID: <20180511144526.GQ13491@kernel.org> References: <1525866228-30321-1-git-send-email-adrian.hunter@intel.com> <1525866228-30321-8-git-send-email-adrian.hunter@intel.com> <20180509170717.GI13491@kernel.org> <363DA0ED52042842948283D2FC38E4649C13DE9E@IRSMSX106.ger.corp.intel.com> <20180510201542.GD4311@kernel.org> <20180510201922.GE4311@kernel.org> <20180510204700.GF4311@kernel.org> <291c0615-2b5c-0076-faeb-720df9ab5c84@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <291c0615-2b5c-0076-faeb-720df9ab5c84@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, May 11, 2018 at 02:18:01PM +0300, Adrian Hunter escreveu: > On 10/05/18 23:47, Arnaldo Carvalho de Melo wrote: > > Em Thu, May 10, 2018 at 05:19:22PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Thu, May 10, 2018 at 05:15:42PM -0300, Arnaldo Carvalho de Melo escreveu: > >>> Em Thu, May 10, 2018 at 07:08:37PM +0000, Hunter, Adrian escreveu: > >>>> Let me know if you want me to post the workaround patches separately, > >>>> otherwise I will wait a bit before sending the patches again. > > > >>> I'll see if I went thru all of the patches already... > > > >> So I looked at the patches posted and one comment is about the terse > >> commit logs for some of the kcore_copy patches, for instance: > > > >> -------------------- > >> In preparation to add more program headers, get rid of kernel_map and > >> modules_map. > >> -------------------- > > > >> Can't this be made a bit more verbose? Lemme re-read the patch... > > > > So you had just one pointers to the kernel map and a module_maps, and > > then this is replaced by kcore_copy__map() that instead of populating > > those fields that are being removed: > > > > - struct phdr_data kernel_map; > > - struct phdr_data modules_map; > > > > Will allocate and add "struct phdr_data" instances to the > > kcore_copy_info->phdrs list, so I propose, to follow convention used > > elsewhere in tools/perf/ that you rename kcore_copy__map() to > > > > kcore_copy_info__addnew(kci, fields) > > > > I would do it as: > > > > struct phdr_data *phdr_data__new(fields) > > { > > return zalloc() + init fields; > > } > > > > struct phdr_data *kcore_copy_info__addnew(kci, fields) > > { > > struct phdr_data *pd = phdr_data__new(fields); > > > > if (pd) > > list_add(&pd->list, &kci->phdrs) > > } > > > > Also please rename pd->list to pd->node, to clarify that it is a node in > > some list, not a list. > > > > The commit log list then could reflect that somehow, with something > > around: > > > > ---------------------- > > > > Move ->kernel_map and ->modules_map to newly allocated entries in the > > ->phdrs list. > > > > ---------------------- > > > > wdyt? > > I have done the changes but still have kcore_copy__map() calling > kcore_copy_info__addnew(). The changes have been pushed to the same branch. Thanks! I'll process a perf/urgent round and then go over your updated tree to get it tested on a skylake machine and merged to perf/core, - arnaldo