From: Matthew Wilcox <willy@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
akpm@linux-foundation.org, mhocko@suse.com, hughd@google.com,
dan.j.williams@intel.com, rientjes@google.com,
mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com,
aneesh.kumar@linux.vnet.ibm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm: Change return type to vm_fault_t
Date: Sat, 12 May 2018 07:24:51 -0700 [thread overview]
Message-ID: <20180512142451.GB24215@bombadil.infradead.org> (raw)
In-Reply-To: <e194731158f7f89145ed0ae28f46aac5726fc32d.camel@perches.com>
On Fri, May 11, 2018 at 11:20:29PM -0700, Joe Perches wrote:
> It'd be nicer to realign the 2nd and 3rd arguments
> on the subsequent lines.
>
> vm_fault_t (*fault)(const struct vm_special_mapping *sm,
> struct vm_area_struct *vma,
> struct vm_fault *vmf);
>
It'd be nicer if people didn't try to line up arguments at all and
just indented by an extra two tabs when they had to break a logical
line due to the 80-column limit.
next prev parent reply other threads:[~2018-05-12 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 6:17 [PATCH v3] mm: Change return type to vm_fault_t Souptick Joarder
2018-05-12 6:20 ` Joe Perches
2018-05-12 6:25 ` Souptick Joarder
2018-05-12 6:26 ` Souptick Joarder
2018-05-12 14:24 ` Matthew Wilcox [this message]
2018-05-12 19:14 ` Souptick Joarder
2018-05-13 2:51 ` Dan Williams
2018-05-13 8:56 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512142451.GB24215@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=hughd@google.com \
--cc=joe@perches.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).