From: David Miller <davem@davemloft.net>
To: ebiggers3@gmail.com
Cc: ubraun@linux.ibm.com, tmricht@linux.vnet.ibm.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org,
ebiggers@google.com
Subject: Re: [PATCH] net/smc: check for missing nlattrs in SMC_PNETID messages
Date: Mon, 14 May 2018 16:41:17 -0400 (EDT) [thread overview]
Message-ID: <20180514.164117.792209096555574754.davem@davemloft.net> (raw)
In-Reply-To: <20180514000130.13780-1-ebiggers3@gmail.com>
From: Eric Biggers <ebiggers3@gmail.com>
Date: Sun, 13 May 2018 17:01:30 -0700
> From: Eric Biggers <ebiggers@google.com>
>
> It's possible to crash the kernel in several different ways by sending
> messages to the SMC_PNETID generic netlink family that are missing the
> expected attributes:
>
> - Missing SMC_PNETID_NAME => null pointer dereference when comparing
> names.
> - Missing SMC_PNETID_ETHNAME => null pointer dereference accessing
> smc_pnetentry::ndev.
> - Missing SMC_PNETID_IBNAME => null pointer dereference accessing
> smc_pnetentry::smcibdev.
> - Missing SMC_PNETID_IBPORT => out of bounds array access to
> smc_ib_device::pattr[-1].
>
> Fix it by validating that all expected attributes are present and that
> SMC_PNETID_IBPORT is nonzero.
>
> Reported-by: syzbot+5cd61039dc9b8bfa6e47@syzkaller.appspotmail.com
> Fixes: 6812baabf24d ("smc: establish pnet table management")
> Cc: <stable@vger.kernel.org> # v4.11+
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-05-14 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 0:01 BUG: unable to handle kernel paging request in smc_ib_remember_port_attr syzbot
2018-05-14 0:01 ` [PATCH] net/smc: check for missing nlattrs in SMC_PNETID messages Eric Biggers
2018-05-14 20:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514.164117.792209096555574754.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tmricht@linux.vnet.ibm.com \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).