linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Bin Liu <b-liu@ti.com>
Subject: [PATCH 4.4 30/56] usb: musb: host: fix potential NULL pointer dereference
Date: Mon, 14 May 2018 08:48:35 +0200	[thread overview]
Message-ID: <20180514064757.697430492@linuxfoundation.org> (raw)
In-Reply-To: <20180514064754.853201981@linuxfoundation.org>

4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Bin Liu <b-liu@ti.com>

commit 2b63f1329df2cd814c1f8353fae4853ace6521d1 upstream.

musb_start_urb() doesn't check the pass-in parameter if it is NULL.  But
in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
returned from first_qh(), which could be NULL.

So wrap the musb_start_urb() call here with a if condition check to
avoid the potential NULL pointer dereference.

Fixes: f283862f3b5c ("usb: musb: NAK timeout scheme on bulk TX endpoint")
Cc: stable@vger.kernel.org # v3.7+
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/musb/musb_host.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -1048,7 +1048,9 @@ static void musb_bulk_nak_timeout(struct
 			/* set tx_reinit and schedule the next qh */
 			ep->tx_reinit = 1;
 		}
-		musb_start_urb(musb, is_in, next_qh);
+
+		if (next_qh)
+			musb_start_urb(musb, is_in, next_qh);
 	}
 }
 

  parent reply	other threads:[~2018-05-14  6:48 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  6:48 [PATCH 4.4 00/56] 4.4.132-stable review Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 01/56] perf/core: Fix the perf_cpu_time_max_percent check Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 02/56] bpf: map_get_next_key to return first key on NULL Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 03/56] KVM: s390: Enable all facility bits that are known good for passthrough Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 04/56] percpu: include linux/sched.h for cond_resched() Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 05/56] mac80211: allow not sending MIC up from driver for HW crypto Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 06/56] mac80211: allow same PN for AMSDU sub-frames Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 07/56] mac80211: Add RX flag to indicate ICV stripped Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 08/56] ath10k: fix rfc1042 header retrieval in QCA4019 with eth decap mode Greg Kroah-Hartman
2018-06-04 17:52   ` Ben Hutchings
2018-06-07 11:52     ` Sriram R
2018-06-07 15:49       ` Ben Hutchings
2018-06-07 16:16         ` Greg Kroah-Hartman
2018-06-07 16:42           ` Ben Hutchings
2018-07-05 16:20             ` Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 09/56] ath10k: rebuild crypto header in rx data frames Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 10/56] gpmi-nand: Handle ECC Errors in erased pages Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 11/56] USB: serial: option: Add support for Quectel EP06 Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 12/56] ALSA: pcm: Check PCM state at xfern compat ioctl Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 13/56] ALSA: seq: Fix races at MIDI encoding in snd_virmidi_output_trigger() Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 14/56] ALSA: aloop: Mark paused device as inactive Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 15/56] ALSA: aloop: Add missing cable lock to ctl API callbacks Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 16/56] tracepoint: Do not warn on ENOMEM Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 17/56] Input: leds - fix out of bound access Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 18/56] Input: atmel_mxt_ts - add touchpad button mapping for Samsung Chromebook Pro Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 19/56] xfs: prevent creating negative-sized file via INSERT_RANGE Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 20/56] RDMA/ucma: Allow resolving address w/o specifying source address Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 21/56] RDMA/mlx5: Protect from shift operand overflow Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 22/56] NET: usb: qmi_wwan: add support for ublox R410M PID 0x90b2 Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 23/56] IB/mlx5: Use unlimited rate when static rate is not supported Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 24/56] drm/vmwgfx: Fix a buffer object leak Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 25/56] test_firmware: fix setting old custom fw path back on exit, second try Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 26/56] USB: serial: visor: handle potential invalid device configuration Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 27/56] USB: Accept bulk endpoints with 1024-byte maxpacket Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 28/56] USB: serial: option: reimplement interface masking Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 29/56] USB: serial: option: adding support for ublox R410M Greg Kroah-Hartman
2018-05-14  6:48 ` Greg Kroah-Hartman [this message]
2018-05-14  6:48 ` [PATCH 4.4 31/56] ipvs: fix rtnl_lock lockups caused by start_sync_thread Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 32/56] crypto: af_alg - fix possible uninit-value in alg_bind() Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 33/56] netlink: fix uninit-value in netlink_sendmsg Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 34/56] net: fix rtnh_ok() Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 35/56] net: initialize skb->peeked when cloning Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 36/56] net: fix uninit-value in __hw_addr_add_ex() Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 37/56] dccp: initialize ireq->ir_mark Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 38/56] soreuseport: initialise timewait reuseport field Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 39/56] perf: Remove superfluous allocation error check Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 40/56] tcp: fix TCP_REPAIR_QUEUE bound checking Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 41/56] bdi: Fix oops in wb_workfn() Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 42/56] f2fs: fix a dead loop in f2fs_fiemap() Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 43/56] xfrm_user: fix return value from xfrm_user_rcv_msg Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 44/56] rfkill: gpio: fix memory leak in probe error path Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 45/56] libata: Apply NOLPM quirk for SanDisk SD7UB3Q*G1001 SSDs Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 46/56] tracing: Fix regex_match_front() to not over compare the test string Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 47/56] can: kvaser_usb: Increase correct stats counter in kvaser_usb_rx_can_msg() Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 48/56] net: atm: Fix potential Spectre v1 Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 49/56] atm: zatm: " Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 50/56] Revert "Bluetooth: btusb: Fix quirk for Atheros 1525/QCA6174" Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 51/56] tracing/uprobe_event: Fix strncpy corner case Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 52/56] perf/x86: Fix possible Spectre-v1 indexing for hw_perf_event cache_* Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 53/56] perf/x86/cstate: Fix possible Spectre-v1 indexing for pkg_msr Greg Kroah-Hartman
2018-05-14  6:48 ` [PATCH 4.4 54/56] perf/x86/msr: Fix possible Spectre-v1 indexing in the MSR driver Greg Kroah-Hartman
2018-05-14  6:49 ` [PATCH 4.4 55/56] perf/core: Fix possible Spectre-v1 indexing for ->aux_pages[] Greg Kroah-Hartman
2018-05-14  6:49 ` [PATCH 4.4 56/56] perf/x86: Fix possible Spectre-v1 indexing for x86_pmu::event_map() Greg Kroah-Hartman
2018-05-14  8:09 ` [PATCH 4.4 00/56] 4.4.132-stable review Nathan Chancellor
2018-05-14 12:05 ` kernelci.org bot
2018-05-14 16:20 ` Guenter Roeck
2018-05-14 22:04 ` Shuah Khan
2018-05-15  6:11 ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514064757.697430492@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=b-liu@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).