From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alex Williamson <alex.williamson@redhat.com>,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>,
Jean Delvare <khali@linux-fr.org>,
Christoph Hellwig <hch@infradead.org>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v5 07/23] iommu/vt-d: fix dev iotlb pfsid use
Date: Mon, 14 May 2018 13:38:25 -0700 [thread overview]
Message-ID: <20180514133825.5b166b68@jacob-builder> (raw)
In-Reply-To: <5AF8EBC4.4040104@linux.intel.com>
On Mon, 14 May 2018 09:52:04 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:
> > diff --git a/drivers/iommu/intel-iommu.c
> > b/drivers/iommu/intel-iommu.c index 4623294..732a10f 100644
> > --- a/drivers/iommu/intel-iommu.c
> > +++ b/drivers/iommu/intel-iommu.c
> > @@ -1459,6 +1459,19 @@ static void iommu_enable_dev_iotlb(struct
> > device_domain_info *info) return;
> >
> > pdev = to_pci_dev(info->dev);
> > + /* For IOMMU that supports device IOTLB throttling (DIT),
> > we assign
> > + * PFSID to the invalidation desc of a VF such that IOMMU
> > HW can gauge
> > + * queue depth at PF level. If DIT is not set, PFSID will
> > be treated as
> > + * reserved, which should be set to 0.
> > + */
> > + if (!ecap_dit(info->iommu->ecap))
> > + info->pfsid = 0;
> > + else if (pdev && pdev->is_virtfn) {
> > + if (ecap_(info->iommu->ecap))
> > + dev_warn(&pdev->dev, "SRIOV VF device
> > IOTLB enabled without flow control\n");
>
> I can't understand these two lines.
>
> Isn't the condition always true? What does the error message mean?
you are right, there is no need to check ecap_dit again. thanks!
next prev parent reply other threads:[~2018-05-14 20:38 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 20:53 [PATCH v5 00/23] IOMMU and VT-d driver support for Shared Virtual Address (SVA) Jacob Pan
2018-05-11 20:53 ` [PATCH v5 01/23] iommu: introduce bind_pasid_table API function Jacob Pan
2018-08-23 16:34 ` Auger Eric
2018-08-24 12:47 ` Liu, Yi L
2018-08-24 13:20 ` Auger Eric
2018-08-28 17:04 ` Jacob Pan
2018-08-24 15:00 ` Auger Eric
2018-08-28 5:14 ` Jacob Pan
2018-08-28 8:34 ` Auger Eric
2018-08-28 16:36 ` Jacob Pan
2018-05-11 20:53 ` [PATCH v5 02/23] iommu/vt-d: move device_domain_info to header Jacob Pan
2018-05-11 20:53 ` [PATCH v5 03/23] iommu/vt-d: add a flag for pasid table bound status Jacob Pan
2018-05-13 7:33 ` Lu Baolu
2018-05-14 18:51 ` Jacob Pan
2018-05-13 8:01 ` Lu Baolu
2018-05-14 18:52 ` Jacob Pan
2018-05-11 20:53 ` [PATCH v5 04/23] iommu/vt-d: add bind_pasid_table function Jacob Pan
2018-05-13 9:29 ` Lu Baolu
2018-05-14 20:22 ` Jacob Pan
2018-05-11 20:53 ` [PATCH v5 05/23] iommu: introduce iommu invalidate API function Jacob Pan
2018-05-11 20:53 ` [PATCH v5 06/23] iommu/vt-d: add definitions for PFSID Jacob Pan
2018-05-14 1:36 ` Lu Baolu
2018-05-14 20:30 ` Jacob Pan
2018-05-11 20:53 ` [PATCH v5 07/23] iommu/vt-d: fix dev iotlb pfsid use Jacob Pan
2018-05-14 1:52 ` Lu Baolu
2018-05-14 20:38 ` Jacob Pan [this message]
2018-05-11 20:54 ` [PATCH v5 08/23] iommu/vt-d: support flushing more translation cache types Jacob Pan
2018-05-14 2:18 ` Lu Baolu
2018-05-14 20:46 ` Jacob Pan
2018-05-17 8:44 ` kbuild test robot
2018-05-11 20:54 ` [PATCH v5 09/23] iommu/vt-d: add svm/sva invalidate function Jacob Pan
2018-05-14 3:35 ` Lu Baolu
2018-05-14 20:49 ` Jacob Pan
2018-05-11 20:54 ` [PATCH v5 10/23] iommu: introduce device fault data Jacob Pan
2018-09-21 10:07 ` Auger Eric
2018-09-21 17:05 ` Jacob Pan
2018-09-26 10:20 ` Auger Eric
2018-05-11 20:54 ` [PATCH v5 11/23] driver core: add per device iommu param Jacob Pan
2018-05-14 5:27 ` Lu Baolu
2018-05-14 20:52 ` Jacob Pan
2018-05-11 20:54 ` [PATCH v5 12/23] iommu: add a timeout parameter for prq response Jacob Pan
2018-05-11 20:54 ` [PATCH v5 13/23] iommu: introduce device fault report API Jacob Pan
2018-05-14 6:01 ` Lu Baolu
2018-05-14 20:55 ` Jacob Pan
2018-05-15 6:52 ` Lu Baolu
2018-05-17 11:41 ` Liu, Yi L
2018-05-17 15:59 ` Jacob Pan
2018-05-17 23:22 ` Liu, Yi L
2018-05-21 23:03 ` Jacob Pan
2018-09-06 9:25 ` Auger Eric
2018-09-06 12:42 ` Jean-Philippe Brucker
2018-09-06 13:14 ` Auger Eric
2018-09-06 17:06 ` Jean-Philippe Brucker
2018-09-07 7:11 ` Auger Eric
2018-09-07 11:23 ` Jean-Philippe Brucker
2018-09-14 13:24 ` Auger Eric
2018-09-17 16:57 ` Jacob Pan
2018-09-25 14:58 ` Jean-Philippe Brucker
2018-09-25 22:17 ` Jacob Pan
2018-09-26 10:14 ` Jean-Philippe Brucker
2018-05-11 20:54 ` [PATCH v5 14/23] iommu: introduce page response function Jacob Pan
2018-05-14 6:39 ` Lu Baolu
2018-05-29 16:13 ` Jacob Pan
2018-09-10 14:52 ` Auger Eric
2018-09-10 17:50 ` Jacob Pan
2018-09-10 19:06 ` Auger Eric
2018-05-11 20:54 ` [PATCH v5 15/23] iommu: handle page response timeout Jacob Pan
2018-05-14 7:43 ` Lu Baolu
2018-05-29 16:20 ` Jacob Pan
2018-05-30 7:46 ` Lu Baolu
2018-05-11 20:54 ` [PATCH v5 16/23] iommu/config: add build dependency for dmar Jacob Pan
2018-05-11 20:54 ` [PATCH v5 17/23] iommu/vt-d: report non-recoverable faults to device Jacob Pan
2018-05-14 8:17 ` Lu Baolu
2018-05-29 17:33 ` Jacob Pan
2018-05-11 20:54 ` [PATCH v5 18/23] iommu/intel-svm: report device page request Jacob Pan
2018-05-11 20:54 ` [PATCH v5 19/23] iommu/intel-svm: replace dev ops with fault report API Jacob Pan
2018-05-11 20:54 ` [PATCH v5 20/23] iommu/intel-svm: do not flush iotlb for viommu Jacob Pan
2018-05-11 20:54 ` [PATCH v5 21/23] iommu/vt-d: add intel iommu page response function Jacob Pan
2018-05-11 20:54 ` [PATCH v5 22/23] trace/iommu: add sva trace events Jacob Pan
2018-05-11 20:54 ` [PATCH v5 23/23] iommu: use sva invalidate and device fault trace event Jacob Pan
2018-05-29 15:54 ` [PATCH v5 00/23] IOMMU and VT-d driver support for Shared Virtual Address (SVA) Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514133825.5b166b68@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe.brucker@arm.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).