From: Mark Rutland <mark.rutland@arm.com>
To: Christian Hansen <chansen3@cisco.com>
Cc: catalin.marinas@arm.com, linux@dominikbrodowski.net,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
xe-linux-external@cisco.com
Subject: Re: [PATCH] arm64: allowing mmap to be traced
Date: Mon, 14 May 2018 15:38:52 +0100 [thread overview]
Message-ID: <20180514143852.tmbzqij2t35wjtdy@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <1526308362-45443-1-git-send-email-chansen3@cisco.com>
On Mon, May 14, 2018 at 02:32:42PM +0000, Christian Hansen wrote:
> Adding missing macro which is present all other system calls to
> to mmap declaration for ARM. This allows it to appear as a kernel
> tracing target.
>
> Signed-off-by: Christian Hansen <chansen3@cisco.com>
FWIW, I sent out a patch doing this earlier today [1], which is
identical modulo some spacing.
Mark.
[1] https://lkml.kernel.org/r/20180514094640.27569-17-mark.rutland@arm.com
> ---
> arch/arm64/kernel/sys.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
> index 72981ba..1ccdbfc 100644
> --- a/arch/arm64/kernel/sys.c
> +++ b/arch/arm64/kernel/sys.c
> @@ -27,9 +27,9 @@
> #include <linux/syscalls.h>
> #include <asm/cpufeature.h>
>
> -asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
> - unsigned long prot, unsigned long flags,
> - unsigned long fd, off_t off)
> +SYSCALL_DEFINE6(mmap, unsigned long, addr, unsigned long, len,
> + unsigned long, prot, unsigned long, flags,
> + unsigned long, fd, off_t, off)
> {
> if (offset_in_page(off) != 0)
> return -EINVAL;
> --
> 2.5.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-05-14 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 14:32 [PATCH] arm64: allowing mmap to be traced Christian Hansen
2018-05-14 14:38 ` Mark Rutland [this message]
2018-05-14 15:09 ` Christian Hansen (chansen3)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514143852.tmbzqij2t35wjtdy@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=chansen3@cisco.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).