From: James Hogan <jhogan@kernel.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: Fix ptrace(2) PTRACE_PEEKUSR and PTRACE_POKEUSR accesses to o32 FGRs
Date: Mon, 14 May 2018 23:37:16 +0100 [thread overview]
Message-ID: <20180514223715.GE29541@jamesdev> (raw)
In-Reply-To: <alpine.DEB.2.00.1805141537210.10896@tp.orcam.me.uk>
[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]
On Mon, May 14, 2018 at 04:49:43PM +0100, Maciej W. Rozycki wrote:
> Check the TIF_32BIT_FPREGS task setting of the tracee rather than the
> tracer in determining the layout of floating-point general registers in
> the floating-point context, correcting access to odd-numbered registers
> for o32 tracees where the setting disagrees between the two processes.
>
> Cc: stable@vger.kernel.org # 3.14+
> Fixes: 597ce1723e0f ("MIPS: Support for 64-bit FP with O32 binaries")
> Signed-off-by: Maciej W. Rozycki <macro@mips.com>
> ---
> Hi,
>
> These are not the usual requests used by GDB to access the floating-point
> context, which is likely why it went unnoticed so long. They are only
> used as a fallback in the case where PTRACE_GETFPREGS and PTRACE_SETFPREGS
> requests are not supported, i.e. with ancient kernels.
>
> However to verify an unrelated GDB bug fix I have tweaked GDB to always
> use PTRACE_PEEKUSR and PTRACE_POKEUSR, and then discovered this issue in
> native GDB regression testing, as it showed regressions from corrupt FGR
> contents across numerous tests compared to the usual results. This fix
> removed those regressions then.
>
> Not being typically used does not mean we ought to keep the interface
> broken. Therefore please apply.
Looks good. Applied to fixes branch for 4.17.
Thanks
James
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2018-05-14 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 15:49 [PATCH] MIPS: Fix ptrace(2) PTRACE_PEEKUSR and PTRACE_POKEUSR accesses to o32 FGRs Maciej W. Rozycki
2018-05-14 22:37 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514223715.GE29541@jamesdev \
--to=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@mips.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).