From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753402AbeEONqG (ORCPT ); Tue, 15 May 2018 09:46:06 -0400 Received: from 8bytes.org ([81.169.241.247]:46554 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbeEONqF (ORCPT ); Tue, 15 May 2018 09:46:05 -0400 Date: Tue, 15 May 2018 15:46:03 +0200 From: Joerg Roedel To: Gary R Hook Cc: Randy Dunlap , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Message-ID: <20180515134603.GD18595@8bytes.org> References: <152631818082.18929.13970142119193316487.stgit@sosxen2.amd.com> <152631842907.18929.8819955271544326298.stgit@sosxen2.amd.com> <5e45f38e-cb45-d4a1-f351-30543f787290@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e45f38e-cb45-d4a1-f351-30543f787290@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2018 at 03:00:50PM -0500, Gary R Hook wrote: > This was brought up a few weeks ago in, I believe, version 3 of this patch. > That question was discussed (because that's what I did the first time out), > and _someone_ _else_ asked about why I didn't just do it the way I've done > it here. You don't have this problem if you put the code in amd_iommu.c in an IOMMU_DEBUGFS ifdef. Joerg