From: Peter Zijlstra <peterz@infradead.org>
To: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Juri Lelli <juri.lelli@redhat.com>,
Joel Fernandes <joelaf@google.com>,
Steve Muckle <smuckle@google.com>
Subject: Re: [PATCH 3/3] sched/fair: schedutil: explicit update only when required
Date: Tue, 15 May 2018 18:53:04 +0200 [thread overview]
Message-ID: <20180515165304.GH12217@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180515145343.GJ30654@e110439-lin>
On Tue, May 15, 2018 at 03:53:43PM +0100, Patrick Bellasi wrote:
> On 15-May 12:19, Vincent Guittot wrote:
> > On 14 May 2018 at 18:32, Patrick Bellasi <patrick.bellasi@arm.com> wrote:
> > Yes se becomes NULL only when you reach root domain
root group; domains are something else again ;-)
> Thus, the scheduler knows that we are going to sleep: does is really
> makes sense to send a notification in this case?
It might; esp. on these very slow changing machines.
> What about adding a new explicit callback at the end of:
> update_blocked_averages() ?
>
> Something like:
>
> ---8<---
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index cb77407ba485..6eb0f31c656d 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -7740,6 +7740,9 @@ static void update_blocked_averages(int cpu)
> if (done)
> rq->has_blocked_load = 0;
> #endif
> +
> + cpufreq_update_util(rq, SCHED_CPUFREQ_IDLE);
> +
> rq_unlock_irqrestore(rq, &rf);
> }
> ---8<---
>
> Where we can also pass in a new SCHED_CPUFREQ_IDLE flag just to notify
> schedutil that the CPU is currently IDLE?
>
> Could that work?
Simlarly you could add ENQUEUE/DEQUEUE flags I suppose. But let's do all
that later in separate patches and evaluate the impact separately, OK?
next prev parent reply other threads:[~2018-05-15 16:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 15:05 [PATCH 0/3] Improve schedutil integration for FAIR tasks Patrick Bellasi
2018-05-10 15:05 ` [PATCH 1/3] sched/cpufreq: always consider blocked FAIR utilization Patrick Bellasi
2018-05-11 5:44 ` Viresh Kumar
2018-05-11 9:12 ` Patrick Bellasi
2018-05-14 9:18 ` Vincent Guittot
2018-05-14 16:33 ` Patrick Bellasi
2018-05-10 15:05 ` [PATCH 2/3] sched/fair: util_est: update before schedutil Patrick Bellasi
2018-05-10 15:34 ` Peter Zijlstra
2018-05-11 5:44 ` Viresh Kumar
2018-05-11 8:41 ` Patrick Bellasi
2018-05-10 15:05 ` [PATCH 3/3] sched/fair: schedutil: explicit update only when required Patrick Bellasi
2018-05-10 16:15 ` Peter Zijlstra
2018-05-10 16:54 ` Patrick Bellasi
2018-05-11 5:43 ` Viresh Kumar
2018-05-11 8:42 ` Patrick Bellasi
2018-05-13 6:04 ` Joel Fernandes
2018-05-13 6:25 ` Joel Fernandes
2018-05-14 16:32 ` Patrick Bellasi
2018-05-15 10:19 ` Vincent Guittot
2018-05-15 14:53 ` Patrick Bellasi
2018-05-15 16:53 ` Peter Zijlstra [this message]
2018-05-15 17:25 ` Patrick Bellasi
2018-05-16 7:13 ` Vincent Guittot
2018-05-16 7:12 ` Vincent Guittot
2018-05-16 10:45 ` Patrick Bellasi
2018-05-17 15:17 ` Joel Fernandes
2018-05-24 13:42 ` Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515165304.GH12217@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=smuckle@google.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).