From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: pasha.tatashin@oracle.com, steven.sistare@oracle.com,
daniel.m.jordan@oracle.com, linux-kernel@vger.kernel.org,
jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, gregkh@linuxfoundation.org,
alexander.duyck@gmail.com, tobin@apporbit.com,
andy.shevchenko@gmail.com
Subject: [PATCH v5 0/3] multi-threading device shutdown
Date: Tue, 15 May 2018 22:40:01 -0400 [thread overview]
Message-ID: <20180516024004.28977-1-pasha.tatashin@oracle.com> (raw)
Changelog
v4 - v5
- Addressed comments from Andy Shevchenko and Greg
Kroah-Hartman
- Split the patch into a series of 3 patches in order to
provide a better bisecting, and facilitate with reviewing.
v3 - v4
- Added device_shutdown_serial kernel parameter to disable
multi-threading as suggested by Greg Kroah-Hartman
v2 - v3
- Fixed warning from kbuild test.
- Moved device_lock/device_unlock inside device_shutdown_tree().
v1 - v2
- It turns out we cannot lock more than MAX_LOCK_DEPTH by a single
thread. (By default this value is 48), and is used to detect
deadlocks. So, I re-wrote the code to only lock one devices per
thread instead of pre-locking all devices by the main thread.
- Addressed comments from Tobin C. Harding.
- As suggested by Alexander Duyck removed ixgbe changes. It can be
done as a separate work scaling RTNL mutex.
Do a faster shutdown by calling dev->*->shutdown(dev) in parallel.
device_shutdown() calls these functions for every single device but
only using one thread.
Since, nothing else is running on the machine by the time
device_shutdown() is called, there is no reason not to utilize all the
available CPU resources.
Pavel Tatashin (3):
drivers core: refactor device_shutdown
drivers core: prepare device_shutdown for multi-threading
drivers core: multi-threading device shutdown
drivers/base/core.c | 290 +++++++++++++++++++++++++++++++++++++-------
1 file changed, 243 insertions(+), 47 deletions(-)
--
2.17.0
next reply other threads:[~2018-05-16 2:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 2:40 Pavel Tatashin [this message]
2018-05-16 2:40 ` [PATCH v5 1/3] drivers core: refactor device_shutdown Pavel Tatashin
2018-06-05 16:44 ` Andy Shevchenko
2018-06-05 17:14 ` Pavel Tatashin
2018-05-16 2:40 ` [PATCH v5 2/3] drivers core: prepare device_shutdown for multi-threading Pavel Tatashin
2018-05-16 2:40 ` [PATCH v5 3/3] drivers core: multi-threading device shutdown Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516024004.28977-1-pasha.tatashin@oracle.com \
--to=pasha.tatashin@oracle.com \
--cc=alexander.duyck@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=daniel.m.jordan@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steven.sistare@oracle.com \
--cc=tobin@apporbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).