From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbeEPJyW (ORCPT ); Wed, 16 May 2018 05:54:22 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34414 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752956AbeEPJyS (ORCPT ); Wed, 16 May 2018 05:54:18 -0400 X-Google-Smtp-Source: AB8JxZpduu1QypI0aYT7WwXssDWPTrwzTofacQRGputLS0F5Xe4jxmDx0rvx+KdTO2VLrdVgk+O8Rw== Date: Wed, 16 May 2018 11:54:16 +0200 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com Subject: Re: [PATCH 11/14] net: core: add new/replace rate estimator lock parameter Message-ID: <20180516095416.GH1972@nanopsycho> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-12-git-send-email-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526308035-12484-12-git-send-email-vladbu@mellanox.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, May 14, 2018 at 04:27:12PM CEST, vladbu@mellanox.com wrote: >Extend rate estimator new and replace APIs with additional spinlock >parameter used by lockless actions to protect rate_est pointer from >concurrent modification. > >Signed-off-by: Vlad Buslov [...] > /** > * gen_new_estimator - create a new rate estimator > * @bstats: basic statistics > * @cpu_bstats: bstats per cpu > * @rate_est: rate estimator statistics >+ * @rate_est_lock: rate_est lock (might be NULL) I cannot find a place you actually use this new arg in this patchset. Did I miss it? > * @stats_lock: statistics lock > * @running: qdisc running seqcount > * @opt: rate estimator configuration TLV [...]