From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: akpm@linux-foundation.org, shakeelb@google.com,
viro@zeniv.linux.org.uk, hannes@cmpxchg.org, mhocko@kernel.org,
tglx@linutronix.de, pombredanne@nexb.com,
stummala@codeaurora.org, gregkh@linuxfoundation.org,
sfr@canb.auug.org.au, guro@fb.com, mka@chromium.org,
penguin-kernel@I-love.SAKURA.ne.jp, chris@chris-wilson.co.uk,
longman@redhat.com, minchan@kernel.org, ying.huang@intel.com,
mgorman@techsingularity.net, jbacik@fb.com, linux@roeck-us.net,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
willy@infradead.org, lirongqing@baidu.com,
aryabinin@virtuozzo.com
Subject: Re: [PATCH v5 11/13] mm: Iterate only over charged shrinkers during memcg shrink_slab()
Date: Thu, 17 May 2018 07:16:34 +0300 [thread overview]
Message-ID: <20180517041634.lgkym6gdctya3oq6@esperanza> (raw)
In-Reply-To: <5c0dbd12-8100-61a2-34fd-8878c57195a3@virtuozzo.com>
On Tue, May 15, 2018 at 05:49:59PM +0300, Kirill Tkhai wrote:
> >> @@ -589,13 +647,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
> >> .memcg = memcg,
> >> };
> >>
> >> - /*
> >> - * If kernel memory accounting is disabled, we ignore
> >> - * SHRINKER_MEMCG_AWARE flag and call all shrinkers
> >> - * passing NULL for memcg.
> >> - */
> >> - if (memcg_kmem_enabled() &&
> >> - !!memcg != !!(shrinker->flags & SHRINKER_MEMCG_AWARE))
> >> + if (!!memcg != !!(shrinker->flags & SHRINKER_MEMCG_AWARE))
> >> continue;
> >
> > I want this check gone. It's easy to achieve, actually - just remove the
> > following lines from shrink_node()
> >
> > if (global_reclaim(sc))
> > shrink_slab(sc->gfp_mask, pgdat->node_id, NULL,
> > sc->priority);
>
> This check is not related to the patchset.
Yes, it is. This patch modifies shrink_slab which is used only by
shrink_node. Simplifying shrink_node along the way looks right to me.
> Let's don't mix everything in the single series of patches, because
> after your last remarks it will grow at least up to 15 patches.
Most of which are trivial so I don't see any problem here.
> This patchset can't be responsible for everything.
I don't understand why you balk at simplifying the code a bit while you
are patching related functions anyway.
>
> >>
> >> if (!(shrinker->flags & SHRINKER_NUMA_AWARE))
> >>
next prev parent reply other threads:[~2018-05-17 4:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 9:52 [PATCH v5 00/13] Improve shrink_slab() scalability (old complexity was O(n^2), new is O(n)) Kirill Tkhai
2018-05-10 9:52 ` [PATCH v5 01/13] mm: Assign id to every memcg-aware shrinker Kirill Tkhai
2018-05-13 5:15 ` Vladimir Davydov
2018-05-14 9:03 ` Kirill Tkhai
2018-05-15 3:29 ` Vladimir Davydov
2018-05-10 9:52 ` [PATCH v5 02/13] memcg: Move up for_each_mem_cgroup{, _tree} defines Kirill Tkhai
2018-05-10 9:52 ` [PATCH v5 03/13] mm: Assign memcg-aware shrinkers bitmap to memcg Kirill Tkhai
2018-05-13 16:47 ` Vladimir Davydov
2018-05-14 9:34 ` Kirill Tkhai
2018-05-15 3:54 ` Vladimir Davydov
2018-05-10 9:52 ` [PATCH v5 04/13] mm: Refactoring in workingset_init() Kirill Tkhai
2018-05-10 9:52 ` [PATCH v5 05/13] fs: Refactoring in alloc_super() Kirill Tkhai
2018-05-10 9:53 ` [PATCH v5 06/13] fs: Propagate shrinker::id to list_lru Kirill Tkhai
2018-05-13 16:57 ` Vladimir Davydov
2018-05-10 9:53 ` [PATCH v5 07/13] list_lru: Add memcg argument to list_lru_from_kmem() Kirill Tkhai
2018-05-10 9:53 ` [PATCH v5 08/13] list_lru: Pass dst_memcg argument to memcg_drain_list_lru_node() Kirill Tkhai
2018-05-10 9:53 ` [PATCH v5 09/13] list_lru: Pass lru " Kirill Tkhai
2018-05-10 9:53 ` [PATCH v5 10/13] mm: Set bit in memcg shrinker bitmap on first list_lru item apearance Kirill Tkhai
2018-05-15 4:08 ` Vladimir Davydov
2018-05-10 9:53 ` [PATCH v5 11/13] mm: Iterate only over charged shrinkers during memcg shrink_slab() Kirill Tkhai
2018-05-15 5:44 ` Vladimir Davydov
2018-05-15 10:12 ` Kirill Tkhai
2018-05-17 4:33 ` Vladimir Davydov
2018-05-17 11:39 ` Kirill Tkhai
2018-05-15 14:49 ` Kirill Tkhai
2018-05-17 4:16 ` Vladimir Davydov [this message]
2018-05-17 11:49 ` Kirill Tkhai
2018-05-17 13:51 ` Vladimir Davydov
2018-05-10 9:54 ` [PATCH v5 12/13] mm: Add SHRINK_EMPTY shrinker methods return value Kirill Tkhai
2018-05-10 9:54 ` [PATCH v5 13/13] mm: Clear shrinker bit if there are no objects related to memcg Kirill Tkhai
2018-05-15 5:59 ` Vladimir Davydov
2018-05-15 8:55 ` Kirill Tkhai
2018-05-17 4:49 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517041634.lgkym6gdctya3oq6@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=chris@chris-wilson.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=jbacik@fb.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@roeck-us.net \
--cc=lirongqing@baidu.com \
--cc=longman@redhat.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mka@chromium.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pombredanne@nexb.com \
--cc=sfr@canb.auug.org.au \
--cc=shakeelb@google.com \
--cc=stummala@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).