From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1
Date: Thu, 17 May 2018 08:34:40 -0300 [thread overview]
Message-ID: <20180517083440.14e6b975@vento.lan> (raw)
In-Reply-To: <d34cf31f-6dc5-ee2d-ea6d-513dd5e8e5c3@embeddedor.com>
Em Thu, 17 May 2018 05:36:03 -0500
"Gustavo A. R. Silva" <gustavo@embeddedor.com> escreveu:
>
>
> On 05/16/2018 08:14 PM, Gustavo A. R. Silva wrote:
> >
> >
> > On 05/15/2018 02:39 PM, Dan Carpenter wrote:
> >> You'd need to rebuild the db (possibly twice but definitely once).
How? Here, I just pull from your git tree and do a "make". At most,
make clean; make.
> >>
> >
> > Hi Dan,
> >
> > After rebuilding the db (once), these are all the Spectre media warnings
> > I get:
> >
> > drivers/media/pci/ddbridge/ddbridge-core.c:233 ddb_redirect() warn:
> > potential spectre issue 'ddbs'
> > drivers/media/pci/ddbridge/ddbridge-core.c:243 ddb_redirect() warn:
> > potential spectre issue 'pdev->port'
> > drivers/media/pci/ddbridge/ddbridge-core.c:252 ddb_redirect() warn:
> > potential spectre issue 'idev->input'
> > drivers/media/dvb-core/dvb_ca_en50221.c:1400
> > dvb_ca_en50221_io_do_ioctl() warn: potential spectre issue
> > 'ca->slot_info' (local cap)
> > drivers/media/dvb-core/dvb_ca_en50221.c:1479 dvb_ca_en50221_io_write()
> > warn: potential spectre issue 'ca->slot_info' (local cap)
> > drivers/media/dvb-core/dvb_net.c:252 handle_one_ule_extension() warn:
> > potential spectre issue 'p->ule_next_hdr'
> > drivers/media/dvb-core/dvb_net.c:1483 dvb_net_do_ioctl() warn: potential
> > spectre issue 'dvbnet->device' (local cap)
> > drivers/media/cec/cec-pin-error-inj.c:170 cec_pin_error_inj_parse_line()
> > warn: potential spectre issue 'pin->error_inj_args'
> >
> > I just want to double check if you are getting the same output. In case
> > you are getting the same, then what Mauro commented about these issues:
> >
> > https://patchwork.linuxtv.org/project/linux-media/list/?submitter=7277
> >
> > being resolved by commit 3ad3b7a2ebaefae37a7eafed0779324987ca5e56 seems
> > to be correct.
> >
>
> Interesting, I've rebuild the db twice and now I get a total of 75
> Spectre warnings in drivers/media
That makes more sense to me, as the same pattern is used by almost all
VIDIOC_ENUM_foo ioctls.
Thanks,
Mauro
next prev parent reply other threads:[~2018-05-17 11:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 17:37 [PATCH 00/11] fix potential Spectre variant 1 issues Gustavo A. R. Silva
2018-04-23 17:38 ` [PATCH 01/11] media: tm6000: fix potential Spectre variant 1 Gustavo A. R. Silva
2018-04-23 18:24 ` Mauro Carvalho Chehab
2018-04-23 19:11 ` Gustavo A. R. Silva
2018-04-23 19:17 ` Mauro Carvalho Chehab
2018-04-23 19:22 ` Gustavo A. R. Silva
2018-04-26 21:41 ` Gustavo A. R. Silva
2018-04-26 23:42 ` Mauro Carvalho Chehab
2018-05-15 3:31 ` Gustavo A. R. Silva
2018-05-15 11:59 ` Mauro Carvalho Chehab
2018-05-15 14:16 ` Dan Carpenter
2018-05-15 17:29 ` Gustavo A. R. Silva
2018-05-15 19:00 ` Mauro Carvalho Chehab
2018-05-16 13:11 ` Dan Carpenter
2018-05-16 13:36 ` Mauro Carvalho Chehab
2018-05-15 19:39 ` Dan Carpenter
2018-05-17 1:14 ` Gustavo A. R. Silva
2018-05-17 10:36 ` Gustavo A. R. Silva
2018-05-17 11:34 ` Mauro Carvalho Chehab [this message]
2018-05-17 11:43 ` Mauro Carvalho Chehab
2018-05-17 12:13 ` Mauro Carvalho Chehab
2018-05-17 18:08 ` Gustavo A. R. Silva
2018-05-21 16:18 ` Gustavo A. R. Silva
2018-04-24 9:35 ` Dan Carpenter
2018-04-24 10:11 ` Mauro Carvalho Chehab
2018-04-24 10:36 ` Peter Zijlstra
2018-04-24 11:21 ` Peter Zijlstra
2018-04-24 17:47 ` Mauro Carvalho Chehab
2018-04-24 18:48 ` Peter Zijlstra
2018-04-23 17:38 ` [PATCH 02/11] exynos4-is: mipi-csis: " Gustavo A. R. Silva
2018-04-23 17:39 ` [PATCH 03/11] fsl-viu: " Gustavo A. R. Silva
2018-04-23 17:40 ` [PATCH 04/11] marvell-ccic: mcam-core: " Gustavo A. R. Silva
2018-04-23 17:41 ` [PATCH 05/11] omap_vout: " Gustavo A. R. Silva
2018-04-23 17:47 ` [PATCH 06/11] rcar-v4l2: " Gustavo A. R. Silva
2018-04-23 17:48 ` [PATCH 07/11] rcar_drif: " Gustavo A. R. Silva
2018-04-23 17:48 ` [PATCH 08/11] sh_vou: " Gustavo A. R. Silva
2018-04-23 17:50 ` [PATCH 09/11] vimc-debayer: " Gustavo A. R. Silva
2018-04-23 17:51 ` [PATCH 10/11] vivid-sdr-cap: " Gustavo A. R. Silva
2018-04-23 17:52 ` [PATCH 11/11] vsp1_rwpf: " Gustavo A. R. Silva
2018-04-23 19:13 ` [PATCH 00/11] fix potential Spectre variant 1 issues Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517083440.14e6b975@vento.lan \
--to=mchehab+samsung@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).