From: Michal Hocko <mhocko@kernel.org>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Tony Lindgren <tony@atomide.com>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Laura Abbott <lauraa@codeaurora.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Nazarewicz <mina86@mina86.com>,
Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Will Deacon <will.deacon@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"
Date: Thu, 17 May 2018 19:21:28 +0200 [thread overview]
Message-ID: <20180517172128.GX12670@dhcp22.suse.cz> (raw)
In-Reply-To: <20180517171335.GN23723@intel.com>
On Thu 17-05-18 20:13:35, Ville Syrjälä wrote:
> On Thu, May 17, 2018 at 06:49:47PM +0200, Michal Hocko wrote:
> > On Thu 17-05-18 16:58:32, Ville Syrjälä wrote:
> > > On Thu, May 17, 2018 at 04:36:29PM +0300, Ville Syrjälä wrote:
> > > > On Thu, May 17, 2018 at 03:21:09PM +0200, Michal Hocko wrote:
> > > > > On Thu 17-05-18 15:59:59, Ville Syrjala wrote:
> > > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > >
> > > > > > This reverts commit bad8c6c0b1144694ecb0bc5629ede9b8b578b86e.
> > > > > >
> > > > > > Make x86 with HIGHMEM=y and CMA=y boot again.
> > > > >
> > > > > Is there any bug report with some more details? It is much more
> > > > > preferable to fix the issue rather than to revert the whole thing
> > > > > right away.
> > > >
> > > > The machine I have in front of me right now didn't give me anything.
> > > > Black screen, and netconsole was silent. No serial port on this
> > > > machine unfortunately.
> > >
> > > Booted on another machine with serial:
> >
> > Could you provide your .config please?
>
> Attached. Not sure there's anything particularly useful in it though
> since I've now seen this on all the highmem systems I've booted.
It has CONFIG_HAVE_MEMBLOCK_NODE_MAP so the movable_zone initialization
depends on quite some crazy movable init code paths. So maybe that is
the place to look at.
> BTW I just noticed that the reported memory sizes look pretty crazy:
>
> Memory: 3926480K/3987424K available (5254K kernel code, 561K rwdata,
> 2156K rodata, 572K init, 9308K bss, 56848K reserved,
> 4096K cma-reserved, 3078532K highmem)
>
> vs.
>
> Memory: 7001976K/3987424K available (5254K kernel code, 561K rwdata,
> 2156K rodata, 572K init, 9308K bss, 4291097664K reserved,
> 4096K cma-reserved, 7005012K highmem)
This smells like a fallout. Reserved pages clearly underflowed which
suggested we are initializating more than we should.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-05-17 17:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 12:59 [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE" Ville Syrjala
2018-05-17 13:15 ` Vlastimil Babka
2018-05-17 13:21 ` Michal Hocko
2018-05-17 13:36 ` Ville Syrjälä
2018-05-17 13:50 ` Vlastimil Babka
2018-05-17 13:58 ` Ville Syrjälä
2018-05-17 14:11 ` Ville Syrjälä
2018-05-17 16:49 ` Michal Hocko
2018-05-17 17:08 ` Michal Hocko
2018-05-17 17:53 ` Laura Abbott
2018-05-18 4:01 ` Joonsoo Kim
2018-05-18 17:42 ` Laura Abbott
2018-05-19 14:46 ` Ville Syrjälä
2018-05-21 6:16 ` Joonsoo Kim
2018-05-23 0:02 ` Andrew Morton
2018-05-23 0:09 ` Joonsoo Kim
2018-05-17 17:13 ` Ville Syrjälä
2018-05-17 17:21 ` Michal Hocko [this message]
2018-05-17 19:55 ` Ville Syrjälä
2018-05-23 1:18 js1304
2018-05-23 18:54 ` Laura Abbott
2018-05-24 11:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517172128.GX12670@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=ville.syrjala@linux.intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).