From: Matthias Kaehlcke <mka@chromium.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] PM / devfreq: Remove redundant frequency adjustment from governors
Date: Thu, 17 May 2018 15:41:26 -0700 [thread overview]
Message-ID: <20180517224126.GP19594@google.com> (raw)
In-Reply-To: <20180516211051.78875-1-mka@chromium.org>
On Wed, May 16, 2018 at 02:10:51PM -0700, Matthias Kaehlcke wrote:
> The performance, powersave, simpleondemand and userspace governors
> determine a target frequency and then adjust it according to the
> df->min/max_freq limits that might have been set by user space. This
> adjustment is redundant, it is done in update_devfreq() for any
> governor, right after governor->get_target_freq().
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/devfreq/governor_performance.c | 10 ++--------
> drivers/devfreq/governor_powersave.c | 5 -----
> drivers/devfreq/governor_simpleondemand.c | 7 +------
> drivers/devfreq/governor_userspace.c | 16 ++++------------
> 4 files changed, 7 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/devfreq/governor_performance.c b/drivers/devfreq/governor_performance.c
> index 4d23ecfbd948..31ee30622c00 100644
> --- a/drivers/devfreq/governor_performance.c
> +++ b/drivers/devfreq/governor_performance.c
> @@ -16,14 +16,8 @@
> static int devfreq_performance_func(struct devfreq *df,
> unsigned long *freq)
> {
> - /*
> - * target callback should be able to get floor value as
> - * said in devfreq.h
> - */
> - if (!df->max_freq)
> - *freq = UINT_MAX;
> - else
> - *freq = df->max_freq;
> + *freq = UINT_MAX;
> +
> return 0;
> }
For the record, the frequency adjustment in update_devfreq() is
currently broken for df->max_freq == 0:
https://patchwork.kernel.org/patch/10407827/
next prev parent reply other threads:[~2018-05-17 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180516211119epcas2p4370ceb0c9d959bd1441fa71493a9b0e0@epcas2p4.samsung.com>
2018-05-16 21:10 ` [PATCH] PM / devfreq: Remove redundant frequency adjustment from governors Matthias Kaehlcke
2018-05-17 1:44 ` Chanwoo Choi
2018-05-17 15:47 ` Matthias Kaehlcke
2018-05-17 23:15 ` Chanwoo Choi
2018-05-18 17:38 ` Matthias Kaehlcke
2018-05-17 22:41 ` Matthias Kaehlcke [this message]
2018-05-17 23:18 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517224126.GP19594@google.com \
--to=mka@chromium.org \
--cc=briannorris@chromium.org \
--cc=cw00.choi@samsung.com \
--cc=dianders@chromium.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).