From: Kim Phillips <kim.phillips@arm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Eric Auger <eric.auger@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
Gargi Sharma <gs051095@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Rik van Riel <riel@redhat.com>,
Robin Murphy <robin.murphy@arm.com>,
Russell King <linux@armlinux.org.uk>,
Thierry Reding <treding@nvidia.com>, Todd Kjos <tkjos@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Kim Phillips <kim.phillips@arm.com>
Subject: [PATCH 4/6] coresight: move shared barrier_pkt[] to coresight_priv.h
Date: Thu, 17 May 2018 20:20:22 -0500 [thread overview]
Message-ID: <20180518012024.22645-4-kim.phillips@arm.com> (raw)
In-Reply-To: <20180518012024.22645-1-kim.phillips@arm.com>
barrier_pkt[] is used in various coresight components.
Change barrier_pkt[] to a static definition in the coresight
private header. Needed prior to allowing coresight to be
built as modules.
Suggested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
---
drivers/hwtracing/coresight/coresight-priv.h | 9 ++++++++-
drivers/hwtracing/coresight/coresight.c | 8 --------
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
index 83a6f5b7a683..45de8c15b687 100644
--- a/drivers/hwtracing/coresight/coresight-priv.h
+++ b/drivers/hwtracing/coresight/coresight-priv.h
@@ -57,7 +57,14 @@ static DEVICE_ATTR_RO(name)
#define coresight_simple_reg64(type, name, lo_off, hi_off) \
__coresight_simple_func(type, NULL, name, lo_off, hi_off)
-extern const u32 barrier_pkt[5];
+/*
+ * When losing synchronisation a new barrier packet needs to be inserted at the
+ * beginning of the data collected in a buffer. That way the decoder knows that
+ * it needs to look for another sync sequence.
+ */
+static const u32 barrier_pkt[5] = {0x7fffffff, 0x7fffffff,
+ 0x7fffffff, 0x7fffffff, 0x0};
+
enum etm_addr_type {
ETM_ADDR_TYPE_NONE,
diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
index 29e834aab539..0cbc2948defc 100644
--- a/drivers/hwtracing/coresight/coresight.c
+++ b/drivers/hwtracing/coresight/coresight.c
@@ -46,14 +46,6 @@ static DEFINE_PER_CPU(struct list_head *, tracer_path);
*/
static struct list_head *stm_path;
-/*
- * When losing synchronisation a new barrier packet needs to be inserted at the
- * beginning of the data collected in a buffer. That way the decoder knows that
- * it needs to look for another sync sequence.
- */
-const u32 barrier_pkt[5] = {0x7fffffff, 0x7fffffff,
- 0x7fffffff, 0x7fffffff, 0x0};
-
static int coresight_id_match(struct device *dev, void *data)
{
int trace_id, i_trace_id;
--
2.17.0
next prev parent reply other threads:[~2018-05-18 1:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 19:06 [PATCH 3/4] coresight: allow to build as modules Kim Phillips
2018-05-08 19:31 ` Randy Dunlap
2018-05-08 20:37 ` Kim Phillips
2018-05-09 6:01 ` Randy Dunlap
2018-05-16 19:33 ` [PATCH v2 " Kim Phillips
2018-05-17 7:06 ` Greg Kroah-Hartman
2018-05-18 1:20 ` [PATCH 1/6] coresight: remove CORESIGHT_LINKS_AND_SINKS dependencies and selections Kim Phillips
2018-05-18 1:20 ` [PATCH 2/6] coresight: fix CORESIGHT_STM -- STM dependency Kim Phillips
2018-05-18 1:20 ` [PATCH 3/6] coresight: use IS_ENABLED for CONFIGs that may be modules Kim Phillips
2018-05-18 1:20 ` Kim Phillips [this message]
2018-05-18 1:20 ` [PATCH 5/6] coresight: populate MODULE_AUTHOR, DESCRIPTION, and LICENSEs Kim Phillips
2018-05-22 17:53 ` Mathieu Poirier
2018-05-18 1:20 ` [PATCH 6/6] coresight: allow to build as modules Kim Phillips
2018-05-22 21:39 ` Mathieu Poirier
2018-05-24 23:49 ` Kim Phillips
2018-05-25 17:21 ` Mathieu Poirier
2018-05-25 17:12 ` Suzuki K Poulose
2018-05-25 17:27 ` Mathieu Poirier
2018-05-22 17:31 ` [PATCH 1/6] coresight: remove CORESIGHT_LINKS_AND_SINKS dependencies and selections Mathieu Poirier
2018-05-23 19:51 ` Kim Phillips
2018-05-24 15:32 ` Mathieu Poirier
2018-05-24 23:30 ` Kim Phillips
2018-05-25 15:27 ` Mathieu Poirier
2018-05-25 18:52 ` Kim Phillips
2018-05-25 19:09 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518012024.22645-4-kim.phillips@arm.com \
--to=kim.phillips@arm.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.auger@redhat.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=gs051095@gmail.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=rdunlap@infradead.org \
--cc=riel@redhat.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=tkjos@google.com \
--cc=treding@nvidia.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).