From: Christian Brauner <christian@brauner.io>
To: Tycho Andersen <tycho@tycho.ws>
Cc: linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org,
"Tobin C . Harding" <me@tobin.cc>,
Kees Cook <keescook@chromium.org>,
Akihiro Suda <suda.akihiro@lab.ntt.co.jp>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Tyler Hicks <tyhicks@canonical.com>
Subject: Re: [PATCH v2 0/4] seccomp trap to userspace
Date: Fri, 18 May 2018 16:03:13 +0200 [thread overview]
Message-ID: <20180518140313.GA26297@mailbox.org> (raw)
In-Reply-To: <20180517151218.12850-1-tycho@tycho.ws>
On Thu, May 17, 2018 at 09:12:14AM -0600, Tycho Andersen wrote:
> Hi,
>
> After a while focusing on other things, I finally managed ot get a v2 of
> this series prepared. I believe I've addressed all the feedback from v1,
> except for one major point: switching the communication protocol over
> the fd to nlattr. I looked into doing this, but the kernel stuff for
> dealing with nlattr seems to require an skb (via nlmsg_{new,put} and
> netlink_unicast), which means we need to deal with the netlink sequence
> numbers, portids, and create a socket protocol. I can do this if we
> still think nlattr is necessary, but based on looking at it, it seems
> like a lot of extra code for no real benefit.
Yes, we've had that discussion before and I agree. I fail to see the
benefit here too.
Christian
>
> I've also added support for passing fds. The code itself is simple, but
> the API could/should probably be different, see patch 4 for discussion.
>
> Tycho
>
> Tycho Andersen (4):
> seccomp: add a return code to trap to userspace
> seccomp: make get_nth_filter available outside of CHECKPOINT_RESTORE
> seccomp: add a way to get a listener fd from ptrace
> seccomp: add support for passing fds via USER_NOTIF
>
> arch/Kconfig | 7 +
> include/linux/seccomp.h | 14 +-
> include/uapi/linux/ptrace.h | 2 +
> include/uapi/linux/seccomp.h | 20 +-
> kernel/ptrace.c | 4 +
> kernel/seccomp.c | 480 +++++++++++++++++-
> tools/testing/selftests/seccomp/seccomp_bpf.c | 359 ++++++++++++-
> 7 files changed, 878 insertions(+), 8 deletions(-)
>
> --
> 2.17.0
>
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/containers
prev parent reply other threads:[~2018-05-18 14:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 15:12 [PATCH v2 0/4] seccomp trap to userspace Tycho Andersen
2018-05-17 15:12 ` [PATCH v2 1/4] seccomp: add a return code to " Tycho Andersen
2018-05-17 15:33 ` Oleg Nesterov
2018-05-17 15:39 ` Tycho Andersen
2018-05-17 15:46 ` Oleg Nesterov
2018-05-24 15:28 ` Tycho Andersen
2018-05-18 14:04 ` Christian Brauner
2018-05-18 15:21 ` Tycho Andersen
2018-05-19 0:14 ` kbuild test robot
2018-05-19 5:01 ` kbuild test robot
2018-05-21 22:55 ` Tycho Andersen
2018-05-17 15:12 ` [PATCH v2 2/4] seccomp: make get_nth_filter available outside of CHECKPOINT_RESTORE Tycho Andersen
2018-05-17 15:12 ` [PATCH v2 3/4] seccomp: add a way to get a listener fd from ptrace Tycho Andersen
2018-05-17 15:41 ` Oleg Nesterov
2018-05-17 15:57 ` Tycho Andersen
2018-05-17 15:59 ` Tycho Andersen
2018-05-18 14:05 ` Christian Brauner
2018-05-18 15:10 ` Tycho Andersen
2018-05-17 15:12 ` [PATCH v2 4/4] seccomp: add support for passing fds via USER_NOTIF Tycho Andersen
2018-05-18 14:03 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518140313.GA26297@mailbox.org \
--to=christian@brauner.io \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=me@tobin.cc \
--cc=oleg@redhat.com \
--cc=suda.akihiro@lab.ntt.co.jp \
--cc=tycho@tycho.ws \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).