From: Lukasz Majewski <lukma@denx.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 RESEND] display: panel: Add AUO g070vvn01 display support (800x480)
Date: Sat, 19 May 2018 13:06:57 +0200 [thread overview]
Message-ID: <20180519130657.4904c90f@jawa> (raw)
In-Reply-To: <20180514190849.18723-1-lukma@denx.de>
[-- Attachment #1: Type: text/plain, Size: 3647 bytes --]
Hi Thierry,
> This commit adds support for AUO's 7.0" display.
>
Thierry, shall I perform some more work on this code, or is it
eligible for applying to your tree?
Best regards,
Łukasz
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> ---
> Changes for v3:
> - Remove not used 'bus-format-override = "rgb565";' property
>
> Changes for v2:
> - Add *.txt suffix to the auo,g070wn01 file
> ---
> .../bindings/display/panel/auo,g070vvn01.txt | 29
> ++++++++++++++++++++
> drivers/gpu/drm/panel/panel-simple.c | 31
> ++++++++++++++++++++++ 2 files changed, 60 insertions(+) create mode
> 100644
> Documentation/devicetree/bindings/display/panel/auo,g070vvn01.txt
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/auo,g070vvn01.txt
> b/Documentation/devicetree/bindings/display/panel/auo,g070vvn01.txt
> new file mode 100644 index 000000000000..49e4105378f6 --- /dev/null
> +++
> b/Documentation/devicetree/bindings/display/panel/auo,g070vvn01.txt
> @@ -0,0 +1,29 @@ +AU Optronics Corporation 7.0" FHD (800 x 480) TFT
> LCD panel +
> +Required properties:
> +- compatible: should be "auo,g070vvn01"
> +- backlight: phandle of the backlight device attached to the panel
> +- power-supply: single regulator to provide the supply voltage
> +
> +Required nodes:
> +- port: Parallel port mapping to connect this display
> +
> +This panel needs single power supply voltage. Its backlight is
> conntrolled +via PWM signal.
> +
> +Example:
> +--------
> +
> +Example device-tree definition when connected to iMX6Q based board
> +
> + lcd_panel: lcd-panel {
> + compatible = "auo,g070vvn01";
> + backlight = <&backlight_lcd>;
> + power-supply = <®_display>;
> +
> + port {
> + lcd_panel_in: endpoint {
> + remote-endpoint = <&lcd_display_out>;
> + };
> + };
> + };
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index
> cbf1ab404ee7..d9984bdb5bb5 100644 ---
> a/drivers/gpu/drm/panel/panel-simple.c +++
> b/drivers/gpu/drm/panel/panel-simple.c @@ -581,6 +581,34 @@ static
> const struct panel_desc auo_b133htn01 = { },
> };
>
> +static const struct display_timing auo_g070vvn01_timings = {
> + .pixelclock = { 33300000, 34209000, 45000000 },
> + .hactive = { 800, 800, 800 },
> + .hfront_porch = { 20, 40, 200 },
> + .hback_porch = { 87, 40, 1 },
> + .hsync_len = { 1, 48, 87 },
> + .vactive = { 480, 480, 480 },
> + .vfront_porch = { 5, 13, 200 },
> + .vback_porch = { 31, 31, 29 },
> + .vsync_len = { 1, 1, 3 },
> +};
> +
> +static const struct panel_desc auo_g070vvn01 = {
> + .timings = &auo_g070vvn01_timings,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 152,
> + .height = 91,
> + },
> + .delay = {
> + .prepare = 200,
> + .enable = 50,
> + .disable = 50,
> + .unprepare = 1000,
> + },
> +};
> +
> static const struct drm_display_mode auo_g104sn02_mode = {
> .clock = 40000,
> .hdisplay = 800,
> @@ -2095,6 +2123,9 @@ static const struct of_device_id
> platform_of_match[] = { .compatible = "auo,b133xtn01",
> .data = &auo_b133xtn01,
> }, {
> + .compatible = "auo,g070vvn01",
> + .data = &auo_g070vvn01,
> + }, {
> .compatible = "auo,g104sn02",
> .data = &auo_g104sn02,
> }, {
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-05-19 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 10:15 [PATCH] display: panel: Add AUO g070vvn01 display support (800x480) Lukasz Majewski
2018-04-09 21:19 ` Rob Herring
2018-04-10 10:29 ` [PATCH v2] " Lukasz Majewski
2018-04-10 12:29 ` Rob Herring
2018-05-09 14:15 ` Lukasz Majewski
2018-05-09 15:39 ` [PATCH v2 RESEND] " Lukasz Majewski
2018-05-09 15:43 ` Fabio Estevam
2018-05-09 15:59 ` [PATCH v3] " Lukasz Majewski
2018-05-14 15:36 ` Lukasz Majewski
2018-05-14 18:12 ` Rob Herring
2018-05-14 19:08 ` [PATCH v3 RESEND] " Lukasz Majewski
2018-05-19 11:06 ` Lukasz Majewski [this message]
2018-05-28 7:54 ` Lukasz Majewski
2018-05-29 14:08 ` Lukasz Majewski
2018-05-29 14:26 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519130657.4904c90f@jawa \
--to=lukma@denx.de \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).