LKML Archive on lore.kernel.org
 help / color / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: kbuild-all@01.org, bjorn.andersson@linaro.org, ohad@wizery.com,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH v2] remoteproc: Introduce prepare/unprepare ops for rproc coredump
Date: Tue, 22 May 2018 18:39:56 +0800
Message-ID: <201805221858.4fcVEaBU%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180521184559.20864-1-sibis@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 6496 bytes --]

Hi Sibi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.17-rc6]
[also build test ERROR on next-20180517]
[cannot apply to remoteproc/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sibi-Sankar/remoteproc-Introduce-prepare-unprepare-ops-for-rproc-coredump/20180522-133348
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

   drivers/remoteproc/qcom_q6v5_pil.c: In function 'q6v5_start':
>> drivers/remoteproc/qcom_q6v5_pil.c:796:3: error: implicit declaration of function 'q6v5_enable_irqs'; did you mean 'enable_irq'? [-Werror=implicit-function-declaration]
      q6v5_enable_irqs(qproc);
      ^~~~~~~~~~~~~~~~
      enable_irq
   cc1: some warnings being treated as errors

vim +796 drivers/remoteproc/qcom_q6v5_pil.c

   725	
   726	static int q6v5_start(struct rproc *rproc)
   727	{
   728		struct q6v5 *qproc = (struct q6v5 *)rproc->priv;
   729		int xfermemop_ret;
   730		int ret;
   731	
   732		ret = q6v5_regulator_enable(qproc, qproc->proxy_regs,
   733					    qproc->proxy_reg_count);
   734		if (ret) {
   735			dev_err(qproc->dev, "failed to enable proxy supplies\n");
   736			goto clear_coredump_pending;
   737		}
   738	
   739		ret = q6v5_clk_enable(qproc->dev, qproc->proxy_clks,
   740				      qproc->proxy_clk_count);
   741		if (ret) {
   742			dev_err(qproc->dev, "failed to enable proxy clocks\n");
   743			goto disable_proxy_reg;
   744		}
   745	
   746		ret = q6v5_regulator_enable(qproc, qproc->active_regs,
   747					    qproc->active_reg_count);
   748		if (ret) {
   749			dev_err(qproc->dev, "failed to enable supplies\n");
   750			goto disable_proxy_clk;
   751		}
   752		ret = reset_control_deassert(qproc->mss_restart);
   753		if (ret) {
   754			dev_err(qproc->dev, "failed to deassert mss restart\n");
   755			goto disable_vdd;
   756		}
   757	
   758		ret = q6v5_clk_enable(qproc->dev, qproc->active_clks,
   759				      qproc->active_clk_count);
   760		if (ret) {
   761			dev_err(qproc->dev, "failed to enable clocks\n");
   762			goto assert_reset;
   763		}
   764	
   765		/* Assign MBA image access in DDR to q6 */
   766		xfermemop_ret = q6v5_xfer_mem_ownership(qproc, &qproc->mba_perm, true,
   767							qproc->mba_phys,
   768							qproc->mba_size);
   769		if (xfermemop_ret) {
   770			dev_err(qproc->dev,
   771				"assigning Q6 access to mba memory failed: %d\n",
   772				xfermemop_ret);
   773			goto disable_active_clks;
   774		}
   775	
   776		writel(qproc->mba_phys, qproc->rmb_base + RMB_MBA_IMAGE_REG);
   777	
   778		ret = q6v5proc_reset(qproc);
   779		if (ret)
   780			goto reclaim_mba;
   781	
   782		ret = q6v5_rmb_mba_wait(qproc, 0, 5000);
   783		if (ret == -ETIMEDOUT) {
   784			dev_err(qproc->dev, "MBA boot timed out\n");
   785			goto halt_axi_ports;
   786		} else if (ret != RMB_MBA_XPU_UNLOCKED &&
   787			   ret != RMB_MBA_XPU_UNLOCKED_SCRIBBLED) {
   788			dev_err(qproc->dev, "MBA returned unexpected status %d\n", ret);
   789			ret = -EINVAL;
   790			goto halt_axi_ports;
   791		}
   792	
   793		if (qproc->coredump_pending) {
   794			dev_info(qproc->dev, "MBA booted, skipping mpss for coredump\n");
   795			qproc->coredump_pending = false;
 > 796			q6v5_enable_irqs(qproc);
   797			xfermemop_ret = q6v5_xfer_mem_ownership(qproc,
   798								&qproc->mba_perm, false,
   799								qproc->mba_phys,
   800								qproc->mba_size);
   801			if (xfermemop_ret)
   802				dev_err(qproc->dev, "Failed to reclaim mba buffer\n");
   803			return 0;
   804		}
   805	
   806		dev_info(qproc->dev, "MBA booted, loading mpss\n");
   807	
   808		ret = q6v5_mpss_load(qproc);
   809		if (ret)
   810			goto reclaim_mpss;
   811	
   812		ret = wait_for_completion_timeout(&qproc->start_done,
   813						  msecs_to_jiffies(5000));
   814		if (ret == 0) {
   815			dev_err(qproc->dev, "start timed out\n");
   816			ret = -ETIMEDOUT;
   817			goto reclaim_mpss;
   818		}
   819	
   820		xfermemop_ret = q6v5_xfer_mem_ownership(qproc, &qproc->mba_perm, false,
   821							qproc->mba_phys,
   822							qproc->mba_size);
   823		if (xfermemop_ret)
   824			dev_err(qproc->dev,
   825				"Failed to reclaim mba buffer system may become unstable\n");
   826		qproc->running = true;
   827	
   828		q6v5_clk_disable(qproc->dev, qproc->proxy_clks,
   829				 qproc->proxy_clk_count);
   830		q6v5_regulator_disable(qproc, qproc->proxy_regs,
   831				       qproc->proxy_reg_count);
   832	
   833		return 0;
   834	
   835	reclaim_mpss:
   836		xfermemop_ret = q6v5_xfer_mem_ownership(qproc, &qproc->mpss_perm,
   837							false, qproc->mpss_phys,
   838							qproc->mpss_size);
   839		WARN_ON(xfermemop_ret);
   840	
   841	halt_axi_ports:
   842		q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_q6);
   843		q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_modem);
   844		q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_nc);
   845	
   846	reclaim_mba:
   847		xfermemop_ret = q6v5_xfer_mem_ownership(qproc, &qproc->mba_perm, false,
   848							qproc->mba_phys,
   849							qproc->mba_size);
   850		if (xfermemop_ret) {
   851			dev_err(qproc->dev,
   852				"Failed to reclaim mba buffer, system may become unstable\n");
   853		}
   854	
   855	disable_active_clks:
   856		q6v5_clk_disable(qproc->dev, qproc->active_clks,
   857				 qproc->active_clk_count);
   858	
   859	assert_reset:
   860		reset_control_assert(qproc->mss_restart);
   861	disable_vdd:
   862		q6v5_regulator_disable(qproc, qproc->active_regs,
   863				       qproc->active_reg_count);
   864	disable_proxy_clk:
   865		q6v5_clk_disable(qproc->dev, qproc->proxy_clks,
   866				 qproc->proxy_clk_count);
   867	disable_proxy_reg:
   868		q6v5_regulator_disable(qproc, qproc->proxy_regs,
   869				       qproc->proxy_reg_count);
   870	clear_coredump_pending:
   871		qproc->coredump_pending = false;
   872	
   873		return ret;
   874	}
   875	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 59055 bytes --]

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 18:45 Sibi Sankar
2018-05-22 10:39 ` kbuild test robot [this message]
2018-05-29  5:05 ` Bjorn Andersson
2018-05-29 14:06   ` Sibi S

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201805221858.4fcVEaBU%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=kbuild-all@01.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=sibis@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox