From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched,tracing: Correct trace_sched_pi_setprio() for deboosting
Date: Wed, 23 May 2018 19:28:19 +0200 [thread overview]
Message-ID: <20180523172819.GW12198@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180523141107.6417-1-bigeasy@linutronix.de>
On Wed, May 23, 2018 at 04:11:07PM +0200, Sebastian Andrzej Siewior wrote:
> Since that commit I see during a deboost a task this:
> |futex sched_pi_setprio: comm=futex_requeue_p pid=2234 oldprio=98 newprio=98
> |futex sched_switch: prev_comm=futex_requeue_p prev_pid=2234 prev_prio=120
>
> and after the revert, the `newprio' shows the correct value again:
>
> |futex sched_pi_setprio: comm=futex_requeue_p pid=2220 oldprio=98 newprio=120
> |futex sched_switch: prev_comm=futex_requeue_p prev_pid=2220 prev_prio=120
> @@ -435,7 +435,7 @@ TRACE_EVENT(sched_pi_setprio,
> memcpy(__entry->comm, tsk->comm, TASK_COMM_LEN);
> __entry->pid = tsk->pid;
> __entry->oldprio = tsk->prio;
> - __entry->newprio = pi_task ? pi_task->prio : tsk->prio;
> + __entry->newprio = new_prio;
> /* XXX SCHED_DEADLINE bits missing */
> ),
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 092f7c4de903..888df643b99b 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3823,7 +3823,7 @@ void rt_mutex_setprio(struct task_struct *p, struct task_struct *pi_task)
> goto out_unlock;
> }
>
> - trace_sched_pi_setprio(p, pi_task);
> + trace_sched_pi_setprio(p, prio);
at this point:
prio = pi_task ? min(p->normal_prio, pi->task->prio) : p->normal_prio;
(aka __rt_effective_prio)
Should we put that in the tracepoint instead?
> oldprio = p->prio;
>
> if (oldprio == prio)
next prev parent reply other threads:[~2018-05-23 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 14:11 [PATCH] sched,tracing: Correct trace_sched_pi_setprio() for deboosting Sebastian Andrzej Siewior
2018-05-23 17:28 ` Peter Zijlstra [this message]
2018-05-24 7:44 ` Sebastian Andrzej Siewior
2018-05-24 8:37 ` Peter Zijlstra
2018-05-24 8:41 ` Sebastian Andrzej Siewior
2018-05-24 13:26 ` [PATCH v2] " Sebastian Andrzej Siewior
2018-05-25 9:47 ` [tip:sched/core] sched, tracing: Fix " tip-bot for Sebastian Andrzej Siewior
2018-05-25 9:54 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523172819.GW12198@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).