From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
aik@ozlabs.ru, robh@kernel.org, joe@perches.com,
elfring@users.sourceforge.net, david@gibson.dropbear.id.au,
jasowang@redhat.com, benh@kernel.crashing.org,
mpe@ellerman.id.au, hch@infradead.org
Subject: Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices
Date: Wed, 23 May 2018 21:50:02 +0300 [thread overview]
Message-ID: <20180523213703-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180522063317.20956-1-khandual@linux.vnet.ibm.com>
subj: s/virito/virtio/
On Tue, May 22, 2018 at 12:03:17PM +0530, Anshuman Khandual wrote:
> This adds a hook which a platform can define in order to allow it to
> force the use of the DMA API for all virtio devices even if they don't
> have the VIRTIO_F_IOMMU_PLATFORM flag set. We want to use this to do
> bounce-buffering of data on the new secure pSeries platform, currently
> under development, where a KVM host cannot access all of the memory
> space of a secure KVM guest. The host can only access the pages which
> the guest has explicitly requested to be shared with the host, thus
> the virtio implementation in the guest has to copy data to and from
> shared pages.
>
> With this hook, the platform code in the secure guest can force the
> use of swiotlb for virtio buffers, with a back-end for swiotlb which
> will use a pool of pre-allocated shared pages. Thus all data being
> sent or received by virtio devices will be copied through pages which
> the host has access to.
>
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> ---
> Changes in V2:
>
> The arch callback has been enabled through an weak symbol defintion
> so that it is enabled only for those architectures subscribing to
> this new framework. Clarified the patch description. The primary
> objective for this RFC has been to get an in principle agreement
> on this approach.
>
> Original V1:
>
> Original RFC and discussions https://patchwork.kernel.org/patch/10324405/
I re-read that discussion and I'm still unclear on the
original question, since I got several apparently
conflicting answers.
I asked:
Why isn't setting VIRTIO_F_IOMMU_PLATFORM on the
hypervisor side sufficient?
> arch/powerpc/include/asm/dma-mapping.h | 6 ++++++
> arch/powerpc/platforms/pseries/iommu.c | 11 +++++++++++
> drivers/virtio/virtio_ring.c | 10 ++++++++++
> 3 files changed, 27 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h
> index 8fa3945..056e578 100644
> --- a/arch/powerpc/include/asm/dma-mapping.h
> +++ b/arch/powerpc/include/asm/dma-mapping.h
> @@ -115,4 +115,10 @@ extern u64 __dma_get_required_mask(struct device *dev);
> #define ARCH_HAS_DMA_MMAP_COHERENT
>
> #endif /* __KERNEL__ */
> +
> +#define platform_forces_virtio_dma platform_forces_virtio_dma
> +
> +struct virtio_device;
> +
> +extern bool platform_forces_virtio_dma(struct virtio_device *vdev);
> #endif /* _ASM_DMA_MAPPING_H */
> diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c
> index 06f0296..a2ec15a 100644
> --- a/arch/powerpc/platforms/pseries/iommu.c
> +++ b/arch/powerpc/platforms/pseries/iommu.c
> @@ -38,6 +38,7 @@
> #include <linux/of.h>
> #include <linux/iommu.h>
> #include <linux/rculist.h>
> +#include <linux/virtio.h>
> #include <asm/io.h>
> #include <asm/prom.h>
> #include <asm/rtas.h>
> @@ -1396,3 +1397,13 @@ static int __init disable_multitce(char *str)
> __setup("multitce=", disable_multitce);
>
> machine_subsys_initcall_sync(pseries, tce_iommu_bus_notifier_init);
> +
> +bool platform_forces_virtio_dma(struct virtio_device *vdev)
> +{
> + /*
> + * On protected guest platforms, force virtio core to use DMA
> + * MAP API for all virtio devices. But there can also be some
> + * exceptions for individual devices like virtio balloon.
> + */
> + return (of_find_compatible_node(NULL, NULL, "ibm,ultravisor") != NULL);
> +}
Isn't this kind of slow? vring_use_dma_api is on
data path and supposed to be very fast.
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 21d464a..47ea6c3 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -141,8 +141,18 @@ struct vring_virtqueue {
> * unconditionally on data path.
> */
>
> +#ifndef platform_forces_virtio_dma
> +static inline bool platform_forces_virtio_dma(struct virtio_device *vdev)
> +{
> + return false;
> +}
> +#endif
> +
> static bool vring_use_dma_api(struct virtio_device *vdev)
> {
> + if (platform_forces_virtio_dma(vdev))
> + return true;
> +
> if (!virtio_has_iommu_quirk(vdev))
> return true;
>
> --
> 2.9.3
next prev parent reply other threads:[~2018-05-23 18:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 6:33 [RFC V2] virtio: Add platform specific DMA API translation for virito devices Anshuman Khandual
2018-05-23 18:50 ` Michael S. Tsirkin [this message]
2018-05-23 22:27 ` Benjamin Herrenschmidt
2018-05-24 7:17 ` Christoph Hellwig
2018-05-25 17:45 ` Michael S. Tsirkin
2018-05-28 23:48 ` Benjamin Herrenschmidt
2018-05-28 23:56 ` Benjamin Herrenschmidt
2018-05-29 14:03 ` Christoph Hellwig
2018-05-29 22:13 ` Benjamin Herrenschmidt
2018-06-04 8:57 ` David Gibson
2018-06-04 9:48 ` Benjamin Herrenschmidt
2018-06-04 12:50 ` Michael S. Tsirkin
2018-06-05 1:52 ` David Gibson
2018-06-04 12:43 ` Michael S. Tsirkin
2018-06-04 12:55 ` Christoph Hellwig
2018-06-04 13:14 ` Benjamin Herrenschmidt
2018-06-04 16:34 ` Michael S. Tsirkin
2018-06-04 13:11 ` Benjamin Herrenschmidt
2018-06-04 16:21 ` Michael S. Tsirkin
2018-06-04 23:26 ` Benjamin Herrenschmidt
2018-06-05 1:25 ` Michael S. Tsirkin
2018-06-05 4:52 ` Christoph Hellwig
2018-05-24 7:21 ` Ram Pai
2018-05-31 3:39 ` Anshuman Khandual
2018-05-31 17:43 ` Michael S. Tsirkin
2018-06-07 5:23 ` Christoph Hellwig
2018-06-07 16:28 ` Michael S. Tsirkin
2018-06-08 6:36 ` Christoph Hellwig
2018-06-13 13:49 ` Michael S. Tsirkin
2018-06-11 2:39 ` Ram Pai
2018-06-11 3:28 ` Michael S. Tsirkin
2018-06-11 3:34 ` Benjamin Herrenschmidt
2018-06-13 14:23 ` Michael S. Tsirkin
2018-06-11 3:29 ` Benjamin Herrenschmidt
2018-06-13 7:41 ` Christoph Hellwig
2018-06-13 12:25 ` Benjamin Herrenschmidt
2018-06-13 13:11 ` Benjamin Herrenschmidt
2018-06-15 9:16 ` Christoph Hellwig
2018-06-16 1:07 ` Benjamin Herrenschmidt
2018-06-13 13:59 ` Michael S. Tsirkin
2018-06-13 14:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523213703-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=elfring@users.sourceforge.net \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=joe@perches.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=robh@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).