From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>, Ian Ray <ian.ray@ge.com>,
Nandor Han <nandor.han@ge.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv4 1/2] ARM: imx53: add secure-reg-access support for PMU
Date: Mon, 28 May 2018 17:50:42 +0200 [thread overview]
Message-ID: <20180528155042.ilmyqe4z5gekakrl@earth.universe> (raw)
In-Reply-To: <20180528072034.GB3143@dragon>
[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]
Hi,
On Mon, May 28, 2018 at 03:20:35PM +0800, Shawn Guo wrote:
> On Mon, May 28, 2018 at 08:41:31AM +0200, Sebastian Reichel wrote:
> > > Are you saying this is a very specific setup required by i.MX53 only?
> >
> > Yes, all other SoCs supported by Linux ARM PMU counters driver can
> > just use the registers without having to enable platform specific
> > bits first.
> >
> > > In that case, I can live with it.
> >
> > What about the DT node? I did not add it, since this is a i.MX53
> > specific workaround anyways.
>
> What you are adding here is secure-reg-access property, which has an
> defined meaning in PMU binding doc. I'm not really sure if it's
> appropriate to use the property as a condition for DBGEN bit setup.
> Or can we set up the bit regardless of the property?
The description for DBGEN bit is:
> Debug enable. This allows the user to manually activate clocks
> within the debug system. This register bit directly controls the
> platform's dbgen_out output signal which connects to the DAP_SYS to
> enable all debug clocks. Once enabled, the clocks cannot be disabled
> except by asserting the disable_trace input of the DAP_SYS.
I only enable this bit when the kernel configuration allows
using the PMU, since otherwise we do not need the clocks
in the debug system. This limits any potential side-effects
of this patchset.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-28 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 12:39 [PATCHv4 0/2] Improved perf support for imx53/ppd Sebastian Reichel
2018-02-12 12:39 ` [PATCHv4 1/2] ARM: imx53: add secure-reg-access support for PMU Sebastian Reichel
2018-02-12 12:48 ` Fabio Estevam
2018-02-24 7:45 ` Shawn Guo
2018-02-26 13:47 ` Sebastian Reichel
2018-02-27 1:10 ` Shawn Guo
2018-02-27 10:17 ` Sebastian Reichel
2018-05-25 15:45 ` Sebastian Reichel
2018-05-28 2:26 ` Shawn Guo
2018-05-28 6:41 ` Sebastian Reichel
2018-05-28 7:20 ` Shawn Guo
2018-05-28 15:50 ` Sebastian Reichel [this message]
2018-06-18 4:00 ` Fabio Estevam
2018-02-12 12:39 ` [PATCHv4 2/2] ARM: dts: imx53: PPD: Enable secure-reg-access Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528155042.ilmyqe4z5gekakrl@earth.universe \
--to=sebastian.reichel@collabora.co.uk \
--cc=fabio.estevam@nxp.com \
--cc=ian.ray@ge.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nandor.han@ge.com \
--cc=shawnguo@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).