From: Mike Snitzer <snitzer@redhat.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Mikulas Patocka <mpatocka@redhat.com>,
Shaohua Li <shli@kernel.org>, Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com, Matthew Wilcox <mawilcox@microsoft.com>,
linux-fsdevel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Heinz Mauelshagen <heinzm@redhat.com>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: dm-writecache: fix compilation issue with !DAX
Date: Tue, 29 May 2018 14:08:23 -0400 [thread overview]
Message-ID: <20180529180823.GA32763@redhat.com> (raw)
In-Reply-To: <20180529175216.24937-1-ross.zwisler@linux.intel.com>
On Tue, May 29 2018 at 1:52pm -0400,
Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> As reported by Arnd (https://lkml.org/lkml/2018/5/28/1697), dm-writecache
> will fail with link errors in configs where DAX isn't present:
>
> drivers/md/dm-writecache.o: In function `writecache_ctr':
> dm-writecache.c:(.text+0x1fdc): undefined reference to `dax_read_lock'
> dm-writecache.c:(.text+0x2004): undefined reference to `dax_direct_access'
> dm-writecache.c:(.text+0x21cc): undefined reference to `dax_read_unlock'
>
> Fix this by following the lead of the other DM modules and wrapping calls
> to the generic DAX code in #if IS_ENABLED(CONFIG_DAX_DRIVER) blocks.
>
> We also expand the failure case for the 'p' (persistent memory) flag so
> that fails on both architectures that don't support persistent memory and
> on kernels that don't have DAX support configured. This prevents us from
> ever hitting the BUG() in the persistent_memory_claim() stub.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
Thanks, I've picked this up.
Mike
next prev parent reply other threads:[~2018-05-29 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 15:38 [PATCH] dm: writecache: add DAX dependency Arnd Bergmann
2018-05-28 18:18 ` Dan Williams
2018-05-29 13:06 ` Mike Snitzer
2018-05-29 15:17 ` [PATCH] " Ross Zwisler
2018-05-29 17:52 ` [PATCH] dm-writecache: fix compilation issue with !DAX Ross Zwisler
2018-05-29 18:08 ` Mike Snitzer [this message]
2018-05-29 18:40 ` Dan Williams
2018-05-29 19:57 ` Mike Snitzer
2018-05-30 12:22 ` [PATCH] " Mikulas Patocka
2018-05-30 13:13 ` Mike Snitzer
2018-05-30 12:21 ` [PATCH] dm: writecache: add DAX dependency Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529180823.GA32763@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=heinzm@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mpatocka@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).