From: Matthias Kaehlcke <mka@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling
Date: Tue, 29 May 2018 14:30:47 -0700 [thread overview]
Message-ID: <20180529213047.GK168650@google.com> (raw)
In-Reply-To: <20180528080826.GA17162@kroah.com>
On Mon, May 28, 2018 at 10:08:26AM +0200, Greg Kroah-Hartman wrote:
> On Fri, May 25, 2018 at 01:30:41PM -0700, Matthias Kaehlcke wrote:
> > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> > index 20be70c3f118..01a1714dd2ad 100644
> > --- a/drivers/misc/Makefile
> > +++ b/drivers/misc/Makefile
> > @@ -57,3 +57,4 @@ obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o
> > obj-$(CONFIG_PCI_ENDPOINT_TEST) += pci_endpoint_test.o
> > obj-$(CONFIG_OCXL) += ocxl/
> > obj-$(CONFIG_MISC_RTSX) += cardreader/
> > +obj-y += throttler/
>
> Shouldn't you depend on a Kconfig option to traverse into this
> directory?
Ack
> > diff --git a/drivers/misc/throttler/Kconfig b/drivers/misc/throttler/Kconfig
> > new file mode 100644
> > index 000000000000..ef8388f6bc0a
> > --- /dev/null
> > +++ b/drivers/misc/throttler/Kconfig
> > @@ -0,0 +1,13 @@
> > +menuconfig THROTTLER
> > + bool "Throttler support"
> > + default n
>
> the default is always 'n' no need to say it again here :)
Will remove
> > + depends on OF
> > + select CPU_FREQ
> > + select PM_DEVFREQ
> > + help
> > + This option enables core support for non-thermal throttling of CPUs
> > + and devfreq devices.
> > +
> > + Note that you also need a event monitor module usually called
> > + *_throttler.
> > +
> > diff --git a/drivers/misc/throttler/Makefile b/drivers/misc/throttler/Makefile
> > new file mode 100644
> > index 000000000000..c8d920cee315
> > --- /dev/null
> > +++ b/drivers/misc/throttler/Makefile
> > @@ -0,0 +1 @@
> > +obj-$(CONFIG_THROTTLER) += core.o
> > diff --git a/drivers/misc/throttler/core.c b/drivers/misc/throttler/core.c
> > new file mode 100644
> > index 000000000000..c058d03212b8
> > --- /dev/null
> > +++ b/drivers/misc/throttler/core.c
> > @@ -0,0 +1,373 @@
> > +/*
> > + * Core code for non-thermal throttling
> > + *
> > + * Copyright (C) 2018 Google, Inc.
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + */
>
> Please just use a single SPDX line, like checkpatch.pl would have warned
> you about. No need for the full verbous license boiler-plate text here
> at all.
Ok
next prev parent reply other threads:[~2018-05-29 21:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 20:30 [PATCH 00/11] Add throttler driver for non-thermal throttling Matthias Kaehlcke
2018-05-25 20:30 ` [PATCH 01/11] PM / devfreq: Init user limits from OPP limits, not viceversa Matthias Kaehlcke
2018-05-28 5:26 ` Chanwoo Choi
2018-05-29 18:06 ` Matthias Kaehlcke
2018-05-25 20:30 ` [PATCH 02/11] PM / devfreq: Fix handling of min/max_freq == 0 Matthias Kaehlcke
2018-05-28 6:37 ` Chanwoo Choi
2018-05-29 18:57 ` Matthias Kaehlcke
2018-05-30 8:04 ` Chanwoo Choi
2018-05-30 21:13 ` Matthias Kaehlcke
2018-06-05 9:40 ` Chanwoo Choi
2018-05-25 20:30 ` [PATCH 03/11] PM / devfreq: Remove check for df->max_freq == 0 from governors Matthias Kaehlcke
2018-05-28 5:27 ` Chanwoo Choi
2018-05-25 20:30 ` [PATCH 04/11] PM / devfreq: Remove redundant frequency adjustment " Matthias Kaehlcke
2018-05-28 5:36 ` Chanwoo Choi
2018-05-25 20:30 ` [PATCH 05/11] PM / devfreq: governors: Return device frequency limits instead of user limits Matthias Kaehlcke
2018-05-28 6:56 ` Chanwoo Choi
2018-05-25 20:30 ` [PATCH 06/11] PM / devfreq: Add struct devfreq_policy Matthias Kaehlcke
2018-05-25 20:30 ` [PATCH 07/11] PM / devfreg: Add support policy notifiers Matthias Kaehlcke
2018-05-25 20:30 ` [PATCH 08/11] PM / devfreq: Make update_devfreq() public Matthias Kaehlcke
2018-05-25 20:30 ` [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling Matthias Kaehlcke
2018-05-28 7:32 ` Chanwoo Choi
2018-05-29 20:57 ` Matthias Kaehlcke
2018-05-30 8:08 ` Chanwoo Choi
2018-05-28 8:08 ` Greg Kroah-Hartman
2018-05-29 21:30 ` Matthias Kaehlcke [this message]
2018-05-25 20:30 ` [PATCH 10/11] dt-bindings: misc: add bindings for throttler Matthias Kaehlcke
2018-05-31 16:31 ` Rob Herring
2018-05-31 18:34 ` Matthias Kaehlcke
2018-05-31 20:04 ` Rob Herring
2018-05-31 21:10 ` Matthias Kaehlcke
2018-05-25 20:30 ` [PATCH 11/11] misc/throttler: Add Chrome OS EC throttler Matthias Kaehlcke
2018-05-31 9:05 ` Enric Balletbo Serra
2018-05-31 17:33 ` Matthias Kaehlcke
[not found] ` <CGME20180525203120epcas2p429d60dc21e16f0b53c58e7b1f942858f@epcms1p8>
2018-05-28 3:59 ` [PATCH 02/11] PM / devfreq: Fix handling of min/max_freq == 0 MyungJoo Ham
[not found] ` <CGME20180525203122epcas3p42a494949f50aa933355840b7e46bb0fe@epcms1p2>
2018-05-28 4:51 ` [PATCH 03/11] PM / devfreq: Remove check for df->max_freq == 0 from governors MyungJoo Ham
[not found] ` <CGME20180525203124epcas2p2db3f1996b33348f19a6a91cee55abb0b@epcms1p1>
2018-05-28 4:57 ` [PATCH 04/11] PM / devfreq: Remove redundant frequency adjustment " MyungJoo Ham
[not found] ` <CGME20180525203125epcas3p46c7cac352ede4b0ba5d2b36bc32ad566@epcms1p8>
2018-05-28 5:04 ` [PATCH 05/11] PM / devfreq: governors: Return device frequency limits instead of user limits MyungJoo Ham
2018-05-29 19:32 ` Matthias Kaehlcke
[not found] ` <CGME20180525203128epcas5p138dbf89498c03bc2a9221aa662001fd4@epcms1p3>
2018-05-28 5:19 ` [PATCH 07/11] PM / devfreg: Add support policy notifiers MyungJoo Ham
2018-05-29 20:02 ` Matthias Kaehlcke
[not found] ` <CGME20180525203128epcas2p21a65a88fed7838221d02f6419f58bf26@epcms1p1>
2018-05-28 5:24 ` [PATCH 08/11] PM / devfreq: Make update_devfreq() public MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529213047.GK168650@google.com \
--to=mka@chromium.org \
--cc=arnd@arndb.de \
--cc=briannorris@chromium.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).