From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964780AbeE3Hlo (ORCPT ); Wed, 30 May 2018 03:41:44 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:36452 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030266AbeE3Hlb (ORCPT ); Wed, 30 May 2018 03:41:31 -0400 Date: Wed, 30 May 2018 00:41:30 -0700 From: Christoph Hellwig To: Martin Schwidefsky Cc: Linus Torvalds , linux-kernel , linux-s390 , Heiko Carstens Subject: Re: [GIT PULL] two more s390 bug fixes for 4.17 Message-ID: <20180530074130.GA6927@infradead.org> References: <20180530075920.1f73275a@mschwideX1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530075920.1f73275a@mschwideX1> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - req->completion_data = cqr; > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr; > + Please don't play such tricks. In general your driver structure should have struct request embedded. If for some reason struct dasd_ccw_req has a different life time please create a new structure instead of these hacks. In either way this really doesn't look like a post-rc7 change.