From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
zi.yan@cs.rutgers.edu,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
riel@redhat.com, pasha.tatashin@oracle.com, jschoenh@amazon.de,
Kate Stewart <kstewart@linuxfoundation.org>,
David Rientjes <rientjes@google.com>,
tglx@linutronix.de, Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>,
yang.s@alibaba-inc.com, Minchan Kim <minchan@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org, Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: Change return type to vm_fault_t
Date: Wed, 30 May 2018 04:16:02 -0700 [thread overview]
Message-ID: <20180530111602.GB17450@bombadil.infradead.org> (raw)
In-Reply-To: <CAFqt6zZCX7Ai2w9dV3OvUn=V4Z02H=+FBirjHT3QSU1Fuz+uLQ@mail.gmail.com>
On Wed, May 30, 2018 at 09:10:47AM +0530, Souptick Joarder wrote:
> On Tue, May 29, 2018 at 11:04 PM, Matthew Wilcox <willy@infradead.org> wrote:
> > I see:
> >
> > mm/gup.c:817:15: warning: invalid assignment: |=
> > mm/gup.c:817:15: left side has type int
> > mm/gup.c:817:15: right side has type restricted vm_fault_t
> >
> > are you building with 'c=2' or 'C=2'?
>
> Building with C=2.
> Do I need to enable any separate FLAG ?
Nope. Here's what I have:
willy@bobo:~/kernel/souptick$ make C=2 mm/gup.o
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CHECK arch/x86/purgatory/purgatory.c
CHECK arch/x86/purgatory/sha256.c
CHECK arch/x86/purgatory/string.c
arch/x86/purgatory/../boot/string.c:134:6: warning: symbol 'simple_strtol' was not declared. Should it be static?
CHK include/generated/bounds.h
CHK include/generated/timeconst.h
CHK include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
DESCEND objtool
CHECK scripts/mod/empty.c
CHK scripts/mod/devicetable-offsets.h
CHECK mm/gup.c
mm/gup.c:817:15: warning: invalid assignment: |=
mm/gup.c:817:15: left side has type int
mm/gup.c:817:15: right side has type restricted vm_fault_t
CC mm/gup.o
next prev parent reply other threads:[~2018-05-30 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 14:31 [PATCH] mm: Change return type to vm_fault_t Souptick Joarder
2018-05-29 14:50 ` Matthew Wilcox
2018-05-29 15:55 ` Souptick Joarder
2018-05-29 17:34 ` Matthew Wilcox
2018-05-30 3:40 ` Souptick Joarder
2018-05-30 11:16 ` Matthew Wilcox [this message]
2018-06-02 14:44 ` Souptick Joarder
2018-06-02 14:44 ` Souptick Joarder
2018-06-02 14:55 ` Souptick Joarder
2018-06-02 14:59 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530111602.GB17450@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=jrdr.linux@gmail.com \
--cc=jschoenh@amazon.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=yang.s@alibaba-inc.com \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).