From: Juri Lelli <juri.lelli@redhat.com>
To: Waiman Long <longman@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
luto@amacapital.net, Mike Galbraith <efault@gmx.de>,
torvalds@linux-foundation.org, Roman Gushchin <guro@fb.com>,
Patrick Bellasi <patrick.bellasi@arm.com>
Subject: Re: [PATCH v9 0/7] Enable cpuset controller in default hierarchy
Date: Wed, 30 May 2018 15:05:55 +0200 [thread overview]
Message-ID: <20180530130555.GD3320@localhost.localdomain> (raw)
In-Reply-To: <d74c67ea-43c9-cabb-4303-ecff008412df@redhat.com>
On 30/05/18 08:56, Waiman Long wrote:
> On 05/30/2018 06:13 AM, Juri Lelli wrote:
> > Hi,
> >
> > On 29/05/18 09:41, Waiman Long wrote:
> >> v9:
> >> - Rename cpuset.sched.domain to cpuset.sched.domain_root to better
> >> identify its purpose as the root of a new scheduling domain or
> >> partition.
> >> - Clarify in the document about the purpose of domain_root and
> >> load_balance. Using domain_root is th only way to create new
> >> partition.
> >> - Fix a lockdep warning in update_isolated_cpumask() function.
> >> - Add a new patch to eliminate call to generate_sched_domains() for
> >> v2 when a change in cpu list does not touch a domain_root.
> > I was playing with this and ended up with the situation below:
> >
> > g1/cgroup.controllers:cpuset
> > g1/cgroup.events:populated 0
> > g1/cgroup.max.depth:max
> > g1/cgroup.max.descendants:max
> > g1/cgroup.stat:nr_descendants 1
> > g1/cgroup.stat:nr_dying_descendants 0
> > g1/cgroup.subtree_control:cpuset
> > g1/cgroup.type:domain
> > g1/cpuset.cpus:0-5 <---
> > g1/cpuset.cpus.effective:0-5
> > g1/cpuset.mems.effective:0-1
> > g1/cpuset.sched.domain_root:1 <---
> > g1/cpuset.sched.load_balance:1
> > g1/cpu.stat:usage_usec 0
> > g1/cpu.stat:user_usec 0
> > g1/cpu.stat:system_usec 0
> > g1/g11/cgroup.events:populated 0
> > g1/g11/cgroup.max.descendants:max
> > g1/g11/cpu.stat:usage_usec 0
> > g1/g11/cpu.stat:user_usec 0
> > g1/g11/cpu.stat:system_usec 0
> > g1/g11/cgroup.type:domain
> > g1/g11/cgroup.stat:nr_descendants 0
> > g1/g11/cgroup.stat:nr_dying_descendants 0
> > g1/g11/cpuset.cpus.effective:0-5
> > g1/g11/cgroup.controllers:cpuset
> > g1/g11/cpuset.sched.load_balance:1
> > g1/g11/cpuset.mems.effective:0-1
> > g1/g11/cpuset.cpus:6-11 <---
> > g1/g11/cgroup.max.depth:max
> > g1/g11/cpuset.sched.domain_root:0
> >
> > Should this be allowed? I was expecting subgroup g11 should be
> > restricted to a subset of g1's cpus.
> >
> > Best,
> >
> > - Juri
>
> That shouldn't be allowed.The code is probably missing some checks that
> should have been done. What was the sequence of commands leading to the
> above configuration?
This is a E5-2609 v3 (12 cores) Fedora Server box (with systemd, so
first command is needed to be able to use cpuset controller with v2,
IIUC):
# umount /sys/fs/cgroup/cpuset
# cd /sys/fs/cgroup/unified/
# echo "+cpuset" >cgroup.subtree_control
# mkdir g1
# echo 0-5 >g1/cpuset.cpus
# echo 6-11 >init.scope/cpuset.cpus
# echo 6-11 >machine.slice/cpuset.cpus
# echo 6-11 >system.slice/cpuset.cpus
# echo 6-11 >user.slice/cpuset.cpus
# echo 1 >g1/cpuset.sched.domain_root
# mkdir g1/g11
# echo "+cpuset" > g1/cgroup.subtree_control
# echo 6-11 >g1/g11/cpuset.cpus
# grep -R . g1/*
That should be it. Am I doing something wrong?
Thanks,
- Juri
next prev parent reply other threads:[~2018-05-30 13:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 13:41 [PATCH v9 0/7] Enable cpuset controller in default hierarchy Waiman Long
2018-05-29 13:41 ` [PATCH v9 1/7] cpuset: " Waiman Long
2018-05-29 13:41 ` [PATCH v9 2/7] cpuset: Add new v2 cpuset.sched.domain_root flag Waiman Long
2018-05-30 14:18 ` Juri Lelli
2018-05-30 14:57 ` Waiman Long
2018-05-31 9:49 ` Peter Zijlstra
2018-05-29 13:41 ` [PATCH v9 3/7] cpuset: Add cpuset.sched.load_balance flag to v2 Waiman Long
2018-05-31 10:44 ` Peter Zijlstra
2018-05-31 10:54 ` Peter Zijlstra
2018-05-31 13:36 ` Waiman Long
2018-05-31 12:26 ` Peter Zijlstra
2018-05-31 13:54 ` Waiman Long
2018-05-31 15:20 ` Peter Zijlstra
2018-05-31 15:36 ` Waiman Long
2018-05-31 16:08 ` Peter Zijlstra
2018-05-31 16:42 ` Waiman Long
2018-06-20 14:46 ` Peter Zijlstra
2018-06-21 7:40 ` Waiman Long
2018-05-29 13:41 ` [PATCH v9 4/7] cpuset: Make generate_sched_domains() recognize isolated_cpus Waiman Long
2018-05-29 13:41 ` [PATCH v9 5/7] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root Waiman Long
2018-05-29 13:41 ` [PATCH v9 6/7] cpuset: Don't rebuild sched domains if cpu changes in non-domain root Waiman Long
2018-05-29 13:41 ` [PATCH v9 7/7] cpuset: Allow reporting of sched domain generation info Waiman Long
2018-05-30 10:13 ` [PATCH v9 0/7] Enable cpuset controller in default hierarchy Juri Lelli
2018-05-30 12:56 ` Waiman Long
2018-05-30 13:05 ` Juri Lelli [this message]
2018-05-30 13:47 ` Waiman Long
2018-05-30 13:52 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530130555.GD3320@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).