* [PATCH] autofs: small cleanup in autofs_getpath()
@ 2018-05-31 6:47 Dan Carpenter
2018-05-31 11:51 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-05-31 6:47 UTC (permalink / raw)
To: Ian Kent
Cc: Andrew Morton, Mark Brown, Ingo Molnar, NeilBrown,
Eric W. Biederman, linux-kernel, kernel-janitors
We don't set "*name" so it's slightly nicer to just pass "name" instead
of "&name".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/autofs/waitq.c b/fs/autofs/waitq.c
index 8c858126c751..f6385c6ef0a5 100644
--- a/fs/autofs/waitq.c
+++ b/fs/autofs/waitq.c
@@ -179,7 +179,7 @@ static void autofs_notify_daemon(struct autofs_sb_info *sbi,
}
static int autofs_getpath(struct autofs_sb_info *sbi,
- struct dentry *dentry, char **name)
+ struct dentry *dentry, char *name)
{
struct dentry *root = sbi->sb->s_root;
struct dentry *tmp;
@@ -189,7 +189,7 @@ static int autofs_getpath(struct autofs_sb_info *sbi,
unsigned seq;
rename_retry:
- buf = *name;
+ buf = name;
len = 0;
seq = read_seqbegin(&rename_lock);
@@ -395,7 +395,7 @@ int autofs_wait(struct autofs_sb_info *sbi,
if (IS_ROOT(dentry) && autofs_type_trigger(sbi->type))
qstr.len = sprintf(name, "%p", dentry);
else {
- qstr.len = autofs_getpath(sbi, dentry, &name);
+ qstr.len = autofs_getpath(sbi, dentry, name);
if (!qstr.len) {
kfree(name);
return -ENOENT;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] autofs: small cleanup in autofs_getpath()
2018-05-31 6:47 [PATCH] autofs: small cleanup in autofs_getpath() Dan Carpenter
@ 2018-05-31 11:51 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2018-05-31 11:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ian Kent, Andrew Morton, Mark Brown, Ingo Molnar, NeilBrown,
linux-kernel, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> We don't set "*name" so it's slightly nicer to just pass "name" instead
> of "&name".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
This seems like an obvious and reasonable cleanup.
> diff --git a/fs/autofs/waitq.c b/fs/autofs/waitq.c
> index 8c858126c751..f6385c6ef0a5 100644
> --- a/fs/autofs/waitq.c
> +++ b/fs/autofs/waitq.c
> @@ -179,7 +179,7 @@ static void autofs_notify_daemon(struct autofs_sb_info *sbi,
> }
>
> static int autofs_getpath(struct autofs_sb_info *sbi,
> - struct dentry *dentry, char **name)
> + struct dentry *dentry, char *name)
> {
> struct dentry *root = sbi->sb->s_root;
> struct dentry *tmp;
> @@ -189,7 +189,7 @@ static int autofs_getpath(struct autofs_sb_info *sbi,
> unsigned seq;
>
> rename_retry:
> - buf = *name;
> + buf = name;
> len = 0;
>
> seq = read_seqbegin(&rename_lock);
> @@ -395,7 +395,7 @@ int autofs_wait(struct autofs_sb_info *sbi,
> if (IS_ROOT(dentry) && autofs_type_trigger(sbi->type))
> qstr.len = sprintf(name, "%p", dentry);
> else {
> - qstr.len = autofs_getpath(sbi, dentry, &name);
> + qstr.len = autofs_getpath(sbi, dentry, name);
> if (!qstr.len) {
> kfree(name);
> return -ENOENT;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-31 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-31 6:47 [PATCH] autofs: small cleanup in autofs_getpath() Dan Carpenter
2018-05-31 11:51 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).