From: Joel Fernandes <joel@joelfernandes.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
mingo@kernel.org, rostedt@goodmis.org, tglx@linutronix.de,
raistlin@linux.it, linux-kernel@vger.kernel.org,
juri.lelli@gmail.com, bristot@redhat.com, kernel-team@lge.com
Subject: Re: [RESEND PATCH v3 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up
Date: Thu, 31 May 2018 23:02:43 -0700 [thread overview]
Message-ID: <20180601060243.GA184458@joelaf.mtv.corp.google.com> (raw)
In-Reply-To: <6617f569-6c2f-509c-328e-fad3db73f5df@lge.com>
On Fri, Jun 01, 2018 at 12:07:48PM +0900, Byungchul Park wrote:
>
>
> On 2018-05-25 14:13, Byungchul Park wrote:
> >
> >
> > On 2018-05-09 15:33, Byungchul Park wrote:
> > > On Thu, Jan 11, 2018 at 10:07:16AM +0100, Peter Zijlstra wrote:
> > > >
> > > >
> > > > Sorry for the huge delay on this, but I'll have to postpone further.
> > > > Still busy with meltdown/spectre stuff.
> > >
> > > Please consider this. Even though it's not a big bug, anyway leading
> > > mis-behavior in certain situaions.
> >
> > Could you see this patches, it's been too long since the start tho?
>
> Please, any opinion.
Just my opinion: this patch [1] is just a cosmetic change. I would argue that
there's no readability improvement by wrapping up elements[0].dl. Infact I
even feel that the elements[0].cpu should directly be accessed since both
.cpu and .dl for the 0th element are directly accessed only from one place
(cpudl_find) and only one time, and explicitly accessing index 0 makes it
more clear that this is the root of the max-heap.
IOW I don't see any benefit in hiding it behind a wrapper which hides the
fact that we're accessing the root of the max heap, but I don't terribly hate
this patch and I'm Ok if maintainers and other reviewers think its worth it.
thanks,
- Joel
[1] https://patchwork.kernel.org/patch/10149099/
next prev parent reply other threads:[~2018-06-01 6:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 6:14 [RESEND PATCH v3 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up Byungchul Park
2018-01-08 6:14 ` [RESEND PATCH v3 2/2] sched/deadline: Initialize cp->elements[].cpu to an invalid value Byungchul Park
2018-06-01 6:12 ` [RESEND, v3, " Joel Fernandes
2018-06-01 6:18 ` Joel Fernandes
2018-06-01 7:10 ` Byungchul Park
2018-06-01 15:52 ` Joel Fernandes
2018-06-03 5:20 ` Byungchul Park
2018-01-11 9:07 ` [RESEND PATCH v3 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up Peter Zijlstra
2018-02-09 0:37 ` Byungchul Park
2018-02-26 7:51 ` Byungchul Park
2018-03-13 5:52 ` Byungchul Park
2018-04-23 7:01 ` Byungchul Park
2018-05-09 6:33 ` Byungchul Park
2018-05-25 5:13 ` Byungchul Park
2018-06-01 3:07 ` Byungchul Park
2018-06-01 6:02 ` Joel Fernandes [this message]
2018-06-01 6:30 ` Byungchul Park
-- strict thread matches above, loose matches on Subject: below --
2017-12-28 23:32 Byungchul Park
2017-12-19 1:19 Byungchul Park
2017-12-22 6:53 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601060243.GA184458@joelaf.mtv.corp.google.com \
--to=joel@joelfernandes.org \
--cc=bristot@redhat.com \
--cc=byungchul.park@lge.com \
--cc=juri.lelli@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=raistlin@linux.it \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).