From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Maninder Singh <maninder1.s@samsung.com>,
sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, a.sahrawat@samsung.com,
pankaj.m@samsung.com, v.narang@samsung.com
Subject: Re: [PATCH 2/2] printk: make sure to print log on console.
Date: Fri, 1 Jun 2018 11:09:42 +0200 [thread overview]
Message-ID: <20180601090942.ek3j4bpbhschljrw@pathway.suse.cz> (raw)
In-Reply-To: <20180601085356.kncuat7epkbtythv@pathway.suse.cz>
On Fri 2018-06-01 10:53:56, Petr Mladek wrote:
> On Fri 2018-06-01 13:40:50, Sergey Senozhatsky wrote:
> > On (05/31/18 14:21), Petr Mladek wrote:
> > > >
> > > > Upstream printk has no printing kthread. And we also run
> > > > printk()->console_unlock() with disabled preemption.
> > >
> > > Yes, the comment was wrong
> >
> > Yes, that was the only thing I meant.
> > I really didn't have any time to look at the patch yesterday, just
> > commented on the most obvious thing.
>
> Fair enough.
>
> > > but the problem is real.
> >
> > Yep, could be. But not exactly the way it is described in the commit
> > messages and the patch does not fully address the problem.
> >
> > The patch assumes that all those events happen sequentially. While
> > in reality they can happen in parallel on different CPUs.
> >
> > Example:
> >
> > CPU0 CPU1
> >
> > set console verbose
> >
> > dump_backtrace()
> > {
> > // for (;;) print frames
> > printk("%pS\n", frame0);
> > printk("%pS\n", frame1);
> > printk("%pS\n", frame2);
> > printk("%pS\n", frame3);
> > ... console_loglevel = CONSOLE_LOGLEVEL_SILENT;
> > printk("%pS\n", frame12);
> > printk("%pS\n", frame13);
> > }
> >
> > Part of backtrace or the entire backtrace will be missed, because
> > we read the global console_loglevel. The problem is still there.
>
> [...]
>
> > So I'd say that most likely the following scenarios can suffer:
> >
> > - NMI comes in, sets loglevel to X, printk-s some data, restores the
> > loglevel back to Y
> > - IRQ comes in [like sysrq, etc] comes in and does the same thing
> > - software exception comes in and does the same thing [e.g. bust_spinlocks()
> > at arch/s390/mm/fault.c]
I forgot to say that it was a great point and analyze.
> My view is:
>
> The race with another printk() (console_lock owner) is much more
> likely than a race between two CPUs manipulating console_loglevel.
>
> The proposed patch seems to be in the right direction. It is supposed
> to fix the most likely scenario. We could block it and request full
> solution but I wonder if it is worth it.
>
> I am personally fine with this partial solution for now. We could
> always make it better if people meet the other scenarios.
I am still fine with the partial solution. Well, I will think
more about it before approving any patch.
Best Regards,
Petr
next prev parent reply other threads:[~2018-06-01 9:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180531102246epcas5p2f1cbc6ff217172e12e2f78bb88eb4a7e@epcas5p2.samsung.com>
2018-05-31 10:19 ` [PATCH 2/2] printk: make sure to print log on console Maninder Singh
2018-05-31 10:52 ` Sergey Senozhatsky
2018-05-31 12:21 ` Petr Mladek
2018-06-01 4:40 ` Sergey Senozhatsky
2018-06-01 8:53 ` Petr Mladek
2018-06-01 9:09 ` Petr Mladek [this message]
2018-06-01 9:37 ` Sergey Senozhatsky
2018-06-01 9:18 ` Sergey Senozhatsky
[not found] ` <CGME20180531102246epcas5p2f1cbc6ff217172e12e2f78bb88eb4a7e@epcms5p5>
2018-06-01 8:42 ` Vaneet Narang
2018-06-01 9:34 ` Sergey Senozhatsky
2018-05-31 13:27 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601090942.ek3j4bpbhschljrw@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=a.sahrawat@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).