linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Germann <bastiangermann@fishpost.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Luca Tettamanti <kronos.it@gmail.com>,
	Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: asus_atk0110: Use non-deprecated registration and managed memory
Date: Fri,  1 Jun 2018 17:14:17 +0200	[thread overview]
Message-ID: <20180601151419.15820-1-bastiangermann@fishpost.de> (raw)
In-Reply-To: <8afcabf0-94c2-8068-5252-491494108a0c@roeck-us.net>

This is version 4 of my previously unversioned patch.

Version 2 addresses the issues brought up by Guenter.
The two v1 patches are joined in v2 1/2.
The unnecessary dynamic allocations are now part of the atk_data struct.
devm_kcalloc is used for the attribute array that is created from sensors.
v2 2/2 replaces all dynamic allocations in the driver with the device
managed devm_* versions. All corresponding kfree calls are removed.

Version 3 addresses the issue brought up by Andy.
v3 1/2 is unchanged. v3 2/2 reverses one of the devm_kzalloc changes of v2
because it introduces a memory leak.

v4 1/2 changes the attr_group field to only contain one item.
v4 2/2 is unchanged.

  reply	other threads:[~2018-06-01 15:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 14:01 [PATCH 1/2] hwmon: (asus_atk0110) Replace deprecated device register call Bastian Germann
2018-05-31 14:01 ` [PATCH 2/2] hwmon: (asus_atk0110) Remove unused manual sysfs file management Bastian Germann
2018-05-31 14:28   ` Guenter Roeck
2018-05-31 14:27 ` [PATCH 1/2] hwmon: (asus_atk0110) Replace deprecated device register call Guenter Roeck
2018-05-31 22:56   ` Bastian Germann
2018-05-31 22:57     ` [PATCH 2/2] hwmon: (asus_atk0110) Make use of device managed memory Bastian Germann
2018-06-01  9:54       ` Andy Shevchenko
2018-06-01 11:07         ` [PATCH 1/2] hwmon: (asus_atk0110) Replace deprecated device register call Bastian Germann
2018-06-01 11:07           ` [PATCH 2/2] hwmon: (asus_atk0110) Make use of device managed memory Bastian Germann
2018-06-01 13:28           ` [PATCH 1/2] hwmon: (asus_atk0110) Replace deprecated device register call Guenter Roeck
2018-06-01 15:14             ` Bastian Germann [this message]
2018-06-01 15:14               ` [PATCH v4 " Bastian Germann
2018-06-01 16:35                 ` Guenter Roeck
2018-06-04 20:35                 ` Luca Tettamanti
2018-06-01 15:14               ` [PATCH v4 2/2] hwmon: (asus_atk0110) Make use of device managed memory Bastian Germann
2018-06-01 16:40                 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180601151419.15820-1-bastiangermann@fishpost.de \
    --to=bastiangermann@fishpost.de \
    --cc=jdelvare@suse.com \
    --cc=kronos.it@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).