From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
Ingo Molnar <mingo@redhat.com>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
linux-alpha@vger.kernel.org
Subject: Re: [PATCH 1.5/5] alpha: atomic: provide asm for the fastpath for _atomic_dec_and_lock_irqsave
Date: Mon, 4 Jun 2018 13:48:52 +0200 [thread overview]
Message-ID: <20180604114852.GQ12217@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180604102757.h46feymcfdydl4nz@linutronix.de>
On Mon, Jun 04, 2018 at 12:27:57PM +0200, Sebastian Andrzej Siewior wrote:
> I just looked at Alpha's atomic_dec_and_lock assembly and did something
> that should work for atomic_dec_and_lock_irqsave. I think it works but I
> would prefer for someone from the Alpha-Camp to ack this before it goes
> in. It is not critical because the non-optimized version should work.
I would vote to simply delete this entire file and get alpha on the
generic code.
Afaict, this asm gets the ordering wrong, and I doubt it is much faster
than using atomic_add_unless() in any case (+- the ordering of course).
> arch/alpha/lib/dec_and_lock.c | 33 ++++++++++++++++++++++++++-------
> 1 file changed, 26 insertions(+), 7 deletions(-)
>
> diff --git a/arch/alpha/lib/dec_and_lock.c b/arch/alpha/lib/dec_and_lock.c
> index 069fef7372dc..d29ba1de4f68 100644
> --- a/arch/alpha/lib/dec_and_lock.c
> +++ b/arch/alpha/lib/dec_and_lock.c
> @@ -32,6 +32,28 @@ _atomic_dec_and_lock: \n\
> .previous \n\
> .end _atomic_dec_and_lock");
>
> + asm (".text \n\
> + .global _atomic_dec_and_lock_irqsave \n\
> + .ent _atomic_dec_and_lock_irqsave \n\
> + .align 4 \n\
> +_atomic_dec_and_lock_irqsave: \n\
> + .prologue 0 \n\
> +1: ldl_l $1, 0($16) \n\
> + subl $1, 1, $1 \n\
> + beq $1, 2f \n\
> + stl_c $1, 0($16) \n\
> + beq $1, 4f \n\
> + mb \n\
> + clr $0 \n\
> + ret \n\
> +2: br $29, 3f \n\
> +3: ldgp $29, 0($29) \n\
> + br $atomic_dec_and_lock_irqsave1..ng \n\
> + .subsection 2 \n\
> +4: br 1b \n\
> + .previous \n\
> + .end _atomic_dec_and_lock_irqsave");
> +
> static int __used atomic_dec_and_lock_1(atomic_t *atomic, spinlock_t *lock)
> {
> /* Slow path */
> @@ -43,14 +65,11 @@ static int __used atomic_dec_and_lock_1(atomic_t *atomic, spinlock_t *lock)
> }
> EXPORT_SYMBOL(_atomic_dec_and_lock);
>
> -int _atomic_dec_and_lock_irqsave(atomic_t *atomic, spinlock_t *lock,
> - unsigned long *flags)
> +static int __used atomic_dec_and_lock_irqsave1(atomic_t *atomic,
> + spinlock_t *lock,
> + unsigned long *flags)
> {
> - /* Subtract 1 from counter unless that drops it to 0 (ie. it was 1) */
> - if (atomic_add_unless(atomic, -1, 1))
> - return 0;
> -
> - /* Otherwise do it the slow way */
> + /* Slow way */
> spin_lock_irqsave(lock, *flags);
> if (atomic_dec_and_test(atomic))
> return 1;
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-06-04 11:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 15:45 Introduce atomic_dec_and_lock_irqsave() Sebastian Andrzej Siewior
2018-05-04 15:45 ` [PATCH 1/5] spinlock: atomic_dec_and_lock: Add an irqsave variant Sebastian Andrzej Siewior
2018-06-04 10:25 ` [PATCH 1/5 v2] " Sebastian Andrzej Siewior
2018-06-04 10:27 ` [PATCH 1.5/5] alpha: atomic: provide asm for the fastpath for _atomic_dec_and_lock_irqsave Sebastian Andrzej Siewior
2018-06-04 11:48 ` Peter Zijlstra [this message]
2018-06-04 12:55 ` Sebastian Andrzej Siewior
2018-06-06 11:18 ` [PATCH 0.5/5] alpha: remove custom dec_and_lock() implementation Sebastian Andrzej Siewior
2018-06-06 11:21 ` Sebastian Andrzej Siewior
2018-06-06 11:59 ` Peter Zijlstra
2018-06-12 21:36 ` [tip:locking/urgent] alpha: Remove " tip-bot for Sebastian Andrzej Siewior
2018-05-04 15:45 ` [PATCH 2/5] mm/backing-dev: Use irqsave variant of atomic_dec_and_lock() Sebastian Andrzej Siewior
2018-05-04 15:45 ` [PATCH 3/5] kernel/user: " Sebastian Andrzej Siewior
2018-05-04 15:45 ` [PATCH 4/5] drivers/md/raid5: " Sebastian Andrzej Siewior
2018-05-04 15:45 ` [PATCH 5/5] drivers/md/raid5: Do not disable irq on release_inactive_stripe_list() call Sebastian Andrzej Siewior
2018-05-04 15:54 ` Introduce atomic_dec_and_lock_irqsave() Peter Zijlstra
2018-05-04 16:07 ` Sebastian Andrzej Siewior
2018-05-04 16:21 ` Peter Zijlstra
2018-05-04 16:26 ` Al Viro
2018-05-04 16:38 ` Peter Zijlstra
2018-05-23 13:02 ` Peter Zijlstra
2018-05-30 9:26 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604114852.GQ12217@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anna-maria@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).